Re: new snapshot (may 4)

On May 4, 2006, at 9:26 AM, Jentsch, Olaf wrote:

> Hi Scott,
>
> the log rotation bug has disappeared(!) - great!

Excellent.  Thanks for checking!

> Ok, I'm speaking from the bug, that access.log with daily rotation
> (rollover-period='1D') keeps growing and the archives are periodic  
> copies of
> this expanding access.log.
>
> Now it's truncated at midnight time.
>
> I propose to never change this code again.

:-)

Actually, I'm a bit surprised people didn't see this on the earlier  
versions.  (The 3.0.18 log issue was a different, unrelated bug.)

The latest snapshot is now using a truncate() call on the access.log  
after the archive.  The old code used a delete() call on access.log  
and then reopened it.  On some operating systems, particularly  
windows, the delete call could fail if something else was accessing  
the log.

-- Scott