Re: [APC-DEV] IS_INTERNED for apc + zend mixtures

[email protected] (Rasmus Lerdorf) Wed, 27 Jul 2011 16:07:39 -0700
Newsgroups php.apc.dev
Message-ID <[email protected]>
On 07/27/2011 03:42 PM, Gopal V wrote:
> On Wednesday 27 July 2011 01:22 PM, Rasmus Lerdorf wrote:
>> On 07/27/2011 01:12 PM, Gopal V wrote:
>>> We probably need an override for that so that we can nest multiple
>>> interned blocks which are non contiguous between different modules.
>>
>> Gopal, can you come up with a suggested override patch for the engine
>> and we'll get it committed before the alpha-3 release next week.
> 
> Updated patch for the cases which check IS_INTERNED before interning
> is initialized.
> 
> http://notmysock.org/code/zend-is-interned2.patch
> 
> +
> 
> http://notmysock.org/code/apc-string-intern.patch

That looks ok to me. Commit it. You should have Zend karma now.

-Rasmus