Re: [APC-DEV] IS_INTERNED for apc + zend mixtures

The patch makes the check for interned string mush more expensive :(

Thanks. Dmitry.

On 07/28/2011 01:19 AM, Gopal V wrote:
> On Wednesday 27 July 2011 01:22 PM, Rasmus Lerdorf wrote:
>> On 07/27/2011 01:12 PM, Gopal V wrote:
>>> We probably need an override for that so that we can nest multiple
>>> interned blocks which are non contiguous between different modules.
>>
>> Gopal, can you come up with a suggested override patch for the engine
>> and we'll get it committed before the alpha-3 release next week.
>
> Attached is the patch suggested.
>
> I propose that APC should not modify the CG() variables at all and
> should keep the interned string in its own apc globals.
>
> So the future apc_is_interned_string would have a short-cut for
> APCSG() and then check in CG() (either via calling the original
> function or an explicit check for speed).
>
> Cheers,
> Gopal