Re: [PHP-PEAR] Re: [PHP-CVS] cvs: php4 /pear/Cache/Container db.php phplib.php

On Fri, Mar 02, 2001 at 04:38:32PM +0100, Ulf Wendel wrote:

> > It's nice that you've added this warning, but it still makes this code
> > MySQL-specific (it won't work with PostgreSQL and perhaps other
> > database).
> 
> Where I don't really care about as I won't write slow code to 95% of the
> users. No, I will not commit any changes to this. It's not really hard
> for the few non MySQL users to change this line. There's a clear warning
> in the online docs.

Then what's the point of your using the PEAR database abstraction
layer if it's going to fail for all databases other than MySQL?  If
you really want the MySQL path to be faster, do so conditionally and
don't break the standard code for everyone else.

Also, remember not every PHP end user will have the ability to change
the code.

> I'm not intrested in a discussion on the pro and con of MySQL or any
> other database system. This has nothing to do with the code.

It breaks the code.

-- 
Jon Parise ([email protected])  .  Rochester Inst. of Technology
http://www.csh.rit.edu/~jon/  :  Computer Science House Member