Re: [RFC PATCH v2 31/31] kvx: Add IPI driver
Krzysztof Kozlowski <[email protected]> Sun, 22 Jan 2023 12:54:48 +0100
| Newsgroups | com.redhat.linux-audit,org.infradead.lists.linux-riscv,org.kernel.vger.bpf,org.kernel.vger.linux-arch,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 20/01/2023 15:10, Yann Sionneau wrote:
> +
> +int __init kvx_ipi_ctrl_probe(irqreturn_t (*ipi_irq_handler)(int, void *))
> +{
> + struct device_node *np;
> + int ret;
> + unsigned int ipi_irq;
> + void __iomem *ipi_base;
> +
> + np = of_find_compatible_node(NULL, NULL, "kalray,kvx-ipi-ctrl");
Nope, big no.
Drivers go to drivers, not to arch code. Use proper driver infrastructure.
Best regards,
Krzysztof
--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit