Re: [PATCH v1 26/36] mspro_block: drop nth_page() usage within SG entry
Lorenzo Stoakes <[email protected]> Thu, 28 Aug 2025 18:56:49 +0100
| Newsgroups | com.zx2c4.lists.wireguard,dev.linux.lists.iommu,dev.linux.lists.virtualization,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-riscv,org.kernel.vger.io-uring,org.kernel.vger.kvm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-ide,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-mips,org.kernel.vger.linux-mmc,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 28, 2025 at 12:01:30AM +0200, David Hildenbrand wrote: > It's no longer required to use nth_page() when iterating pages within a > single SG entry, so let's drop the nth_page() usage. > > Acked-by: Ulf Hansson <[email protected]> > Cc: Maxim Levitsky <[email protected]> > Cc: Alex Dubov <[email protected]> > Cc: Ulf Hansson <[email protected]> > Signed-off-by: David Hildenbrand <[email protected]> LGTM, so: Reviewed-by: Lorenzo Stoakes <[email protected]> > --- > drivers/memstick/core/mspro_block.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c > index c9853d887d282..d3f160dc0da4c 100644 > --- a/drivers/memstick/core/mspro_block.c > +++ b/drivers/memstick/core/mspro_block.c > @@ -560,8 +560,7 @@ static int h_mspro_block_transfer_data(struct memstick_dev *card, > t_offset += msb->current_page * msb->page_size; > > sg_set_page(&t_sg, > - nth_page(sg_page(&(msb->req_sg[msb->current_seg])), > - t_offset >> PAGE_SHIFT), > + sg_page(&(msb->req_sg[msb->current_seg])) + (t_offset >> PAGE_SHIFT), > msb->page_size, offset_in_page(t_offset)); > > memstick_init_req_sg(*mrq, msb->data_dir == READ > -- > 2.50.1 >