Re: [PATCH v1 27/36] memstick: drop nth_page() usage within SG entry
Lorenzo Stoakes <[email protected]> Thu, 28 Aug 2025 18:57:37 +0100
| Newsgroups | com.zx2c4.lists.wireguard,dev.linux.lists.iommu,dev.linux.lists.virtualization,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-riscv,org.kernel.vger.io-uring,org.kernel.vger.kvm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-ide,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-mips,org.kernel.vger.linux-mmc,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 28, 2025 at 12:01:31AM +0200, David Hildenbrand wrote: > It's no longer required to use nth_page() when iterating pages within a > single SG entry, so let's drop the nth_page() usage. > > Acked-by: Ulf Hansson <[email protected]> > Cc: Maxim Levitsky <[email protected]> > Cc: Alex Dubov <[email protected]> > Cc: Ulf Hansson <[email protected]> > Signed-off-by: David Hildenbrand <[email protected]> LGTM, so: Reviewed-by: Lorenzo Stoakes <[email protected]> > --- > drivers/memstick/host/jmb38x_ms.c | 3 +-- > drivers/memstick/host/tifm_ms.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c > index cddddb3a5a27f..79e66e30417c1 100644 > --- a/drivers/memstick/host/jmb38x_ms.c > +++ b/drivers/memstick/host/jmb38x_ms.c > @@ -317,8 +317,7 @@ static int jmb38x_ms_transfer_data(struct jmb38x_ms_host *host) > unsigned int p_off; > > if (host->req->long_data) { > - pg = nth_page(sg_page(&host->req->sg), > - off >> PAGE_SHIFT); > + pg = sg_page(&host->req->sg) + (off >> PAGE_SHIFT); > p_off = offset_in_page(off); > p_cnt = PAGE_SIZE - p_off; > p_cnt = min(p_cnt, length); > diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c > index db7f3a088fb09..0b6a90661eee5 100644 > --- a/drivers/memstick/host/tifm_ms.c > +++ b/drivers/memstick/host/tifm_ms.c > @@ -201,8 +201,7 @@ static unsigned int tifm_ms_transfer_data(struct tifm_ms *host) > unsigned int p_off; > > if (host->req->long_data) { > - pg = nth_page(sg_page(&host->req->sg), > - off >> PAGE_SHIFT); > + pg = sg_page(&host->req->sg) + (off >> PAGE_SHIFT); > p_off = offset_in_page(off); > p_cnt = PAGE_SIZE - p_off; > p_cnt = min(p_cnt, length); > -- > 2.50.1 >