[Accel-config] Re: [PATCH v1 1/2] accel-config: Remove cdev related code

On Tue, May 18, 2021 at 08:07:04AM -0700, Dave Jiang
<dave.jiang(a)intel.com> wrote:
> On 5/17/2021 2:50 PM, ramesh.thomas(a)intel.com wrote:
> > From: Ramesh Thomas <ramesh.thomas(a)intel.com>
> >
> > cdev major/minor method of opening idxd char dev will be deprecated.
> > Currently even in non uacce mode the char dev is opened using the device
> > name at /dev/dsa that is returned by accfg_wq_get_user_dev_path()
> 
> I'm concerned about backward compatibility for apps (Intel user libs) 
> that may still use minor/major API. Do we need to provide some sort of 
> backward compatibility (maybe with warnings?) until they get off this 
> train? Especially they have been doing releases already.

I think we can leave the API for now as long as driver has backward
compatibility. Driver was returning error (-6) when cdev_minor was
accessed. The library was trying to validate cdev_minor after enabling a
wq and setting cdev_minor = -1 after wq was disabled. Do you think we
can remove that code?

-Ramesh