[Accel-config] Re: [PATCH v1 1/2] accel-config: Remove cdev related code
Thomas, Ramesh <ramesh.thomas at intel.com>
| Newsgroups | dev.linux.lists.accel-config |
|---|---|
| Message-ID | <BYAPR11MB2535C1117D5E96D40C4BFDBDED2C9@BYAPR11MB2535.namprd11.prod.outlook.com> |
On Mon, May 17, 2021 at 04:58:47PM, Tony Luck wrote: > > Should we add "cdev path : /dev/dsa/..." to the wq listing? > > That's the direction I was thinking (based on the fact that you took > away cdev major/minor > and didn't replace them). > > But it isn't all that equivalent. A command line only solution might > have had a tough time > getting from the major/minor devices to actually opening a device. > > So the answer is maybe ... but only if we can convince ourselves that > somebody is > going to use "accel-config list" to feed into some script that extracts > the pathname > and hands it onto a process to open/mmap. That seems something of a > stretch. accfg_wq_get_user_dev_path() was the replacement. I thought the display of major/minor in the listing was only for informative purpose i.e. user can use that info in their application. Note that there is also a library API to retrieve the major/minor which I think we can leave for now if users are still using it and driver provides backward compatibility. -Ramesh