[Accel-config] Re: [PATCH v1] accel-config: Fix static code analysis issues

Luck, Tony <tony.luck at intel.com>
Newsgroups dev.linux.lists.accel-config
Message-ID <[email protected]>
@@ -615,7 +616,6 @@ err_read:
 	free(wq->wq_buf);
 	free(wq->wq_path);
 err_wq:
-	close(dfd);
 	free(wq);
 	free(path);
 	return NULL;

Maybe I'm not looking at the latest source ... but it looks like there
is one path to this code where dfd isn't closed first. Here:

 640         /* parse uuid only in mdeve wq type */
 641         if (wq->type == ACCFG_WQT_MDEV) {
 642                 ret = uuid_entry_add(ctx, wq, dfd);
 643                 if (ret < 0)
 644                         goto err_wq;
 645         }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.