[Accel-config] Re: [PATCH v1] accel-config: Fix static code analysis issues

On Fri, Dec 04, 2020 at 08:23:53AM, Tony Luck wrote:
> @@ -615,7 +616,6 @@ err_read:
>  free(wq->wq_buf);
>  free(wq->wq_path);
>  err_wq:
> -close(dfd);
>  free(wq);
>  free(path);
>  return NULL;
> 
> Maybe I'm not looking at the latest source ... but it looks like there
> is one path to this code where dfd isn't closed first. Here:
> 
>  640         /* parse uuid only in mdeve wq type */
>  641         if (wq->type == ACCFG_WQT_MDEV) {
>  642                 ret = uuid_entry_add(ctx, wq, dfd);
>  643                 if (ret < 0)
>  644                         goto err_wq;
>  645         }

Yes, that is old code. We removed mdevs from wqs.
Use repo at https://github.com/intel/idxd-config.git pending branch