[Accel-config] Re: [PATCH 0/5] Remove redundant dependencies

Dave Jiang <dave.jiang at intel.com> Wed, 01 Dec 2021 19:37:10 -0700
Newsgroups dev.linux.lists.accel-config
Message-ID <[email protected]>
On 12/1/2021 4:59 PM, Ramesh Thomas wrote:
> libkmod and libudev are not necessary and are removed in this patchset.
> Presence of idxd kernel module is validated and if not loaded, an error
> message is printed before exiting the app. Accel-config will not try to
> load the kernel modules. The asumption is that systems where
> accel-config is run will have the necessary kernel modules already
> installed.
>
> Ramesh Thomas (5):
>    accel-config: Remove use of libkmod
>    accel-config: Remove libkmod dependencies in build files
>    accel-config: Remove references to unused libudev
>    accel-config: Remove libkmod dependencies in build files
>    accel-config: Check for file existence instead of read permission
>
>   Makefile.am.in        |  2 --
>   README.md             |  4 +--
>   accfg-test.spec.in    |  2 --
>   accfg.spec.in         |  2 --
>   accfg/Makefile.am     |  3 +--
>   accfg/accel-config.c  | 40 +++-------------------------
>   accfg/lib/Makefile.am |  4 +--
>   accfg/lib/libaccfg.c  |  4 +--
>   accfg/lib/private.h   | 12 +--------
>   configure.ac          |  2 --
>   debian/control        |  2 --
>   test/Makefile.am      |  2 +-
>   test/core.c           |  1 -
>   test/libaccfg.c       | 61 +++++++------------------------------------
>   14 files changed, 21 insertions(+), 120 deletions(-)

LGTM

Reviewed-by: Dave Jiang <dave.jiang(a)intel.com>