Re: [PATCH v2 RESEND] brcm80211: fmac: Add error handling for brcmf_usb_dl_writeimage()
Arend van Spriel <[email protected]>
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On 4/22/2025 12:43 PM, Markus Elfring wrote: > … >> brcmf_usb_dl_cmd() but dose not check its return value. The > … > > Please avoid typos in such a change description. Please avoid such a stupid comment and just indicate what you think is wrong and give a proper suggestion to what is should be. > >> Add error handling for brcmf_usb_dl_cmd() to jump to error >> handling path if the brcmf_usb_dl_cmd() fails and the >> 'state.state' and the 'state.bytes' are uninitialized. > > This wording is improvable. That is quite a generic wording you use there. Speak your mind and come up with improved feedback. >> Improve the error message to report more detailed error >> information. > > Please offer such an adjustment by a separate update step. > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc3#n81 Nah. The changes are small and within context. The patch is small enough to assure the bar is low enough for swift review. Splitting it up only increases the burden. Regards, Arend