Re: [PATCH v5] brcm80211: fmac: Add error log in brcmf_usb_dl_cmd()
Arend van Spriel <[email protected]>
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 4/22/2025 8:59 AM, Wentao Liang wrote: > In brcmf_usb_dl_cmd(), the error logging is not enough to describe > the error state. And some caller of the brcmf_usb_dl_cmd() does not > handle its error. An error log in brcmf_usb_dl_cmd() is needed to > prevent silent failure. > > Add error handling in brcmf_usb_dl_cmd() to log the command id and > error code in the brcmf_usb_dl_cmd() fails. In this way, every > invocation of the function logs a message upon failure. Acked-by: Arend van Spriel <[email protected]> > Signed-off-by: Wentao Liang <[email protected]> > --- > v5: Remove finalize label. > v4: Fix spelling problem. > v3: Change patch name and comment. Move error log into brcmf_usb_dl_cmd(). > v2: Remove redundant bailing out code. > > .../broadcom/brcm80211/brcmfmac/usb.c | 23 +++++++++++++------ > 1 file changed, 16 insertions(+), 7 deletions(-)