Re: [PATCH 17/45] vpn-util: Add wrappers for GResolv hostname lookup use

Jussi Laakkonen <[email protected]> Fri, 8 Aug 2025 15:36:32 +0300
Newsgroups dev.linux.lists.connman
Message-ID <[email protected]>
Hi Denis,

On 8/4/25 17:39, Denis Kenzior wrote:
> Hi Jussi,
> 
> On 7/11/25 9:27 AM, Jussi Laakkonen wrote:
>> To avoid linking GResolv with every VPN plugin that uses it, add wrappers
>> for the required calls in VPN utils.
> 
> This may need a bit more explanation?  You're still using GResolv types 
> in these functions?  Why can't g_resolv_ be used instead?

I can amend the commit message on this. The issue is that VPN plugins 
can be either builtin, external (or out of code tree plugins), so making 
this wrapper is a bit more straightforward by linking vpnd only with 
gresolv and having the plugins not to care about it?

> 
>> ---
>>   vpn/vpn-util.c | 30 ++++++++++++++++++++++++++++++
>>   vpn/vpn.h      | 10 ++++++++++
>>   2 files changed, 40 insertions(+)
>>
> 
> Regards,
> -Denis

BR,
  Jussi