Re: [PATCH 28/45] inet: Expose __connman_inet_is_any_addr() for plugins to use

Jussi Laakkonen <[email protected]> Fri, 8 Aug 2025 15:40:57 +0300
Newsgroups dev.linux.lists.connman
Message-ID <[email protected]>
Hi Denis,

On 8/4/25 17:57, Denis Kenzior wrote:
> Hi Jussi,
> 
> On 7/11/25 9:27 AM, Jussi Laakkonen wrote:
>> ---
>>   include/inet.h | 1 +
>>   src/inet.c     | 5 +++++
>>   2 files changed, 6 insertions(+)
>>
> 
> <snip>
> 
>> +bool connman_inet_is_any_addr(const char *address, int family)
>> +{
>> +    return __connman_inet_is_any_addr(address, family);
> 
> Might as well just rename __connman_inet_is_any_addr and fixup any users 
> to use __connman_inet_is_any_addr() directly.

It is always an option, yes. Maybe a bit of 
less-changes-and-backwards-compatibility has been in my mind always when 
doing these.

But if you prefer that way it is no biggie, I can make a V2.

> 
>> +}
>> +
>>   struct in6_ifreq {
>>       struct in6_addr ifr6_addr;
>>       __u32 ifr6_prefixlen;
> 
> Regards,
> -Denis

BR,
  Jussi