Re: [PATCH v2 00/23] Amdgpu plugin cleanups and fixes

On Fri, Apr 10, 2026 at 11:55=E2=80=AFAM Tvrtko Ursulin
<[email protected]> wrote:
>
> This series is a subset of previously posted as RFC:
> https://lore.kernel.org/criu/CAEWA0a4ghpPeQjg1ETiQysGj5agfWwJRvMbWzhrYL5r=
[email protected]/T/#mfb4ab4866a0cb440961be7170d0e107fab7eedf2
>
> And as v1 cleanups only:
> https://lore.kernel.org/criu/5e99e181-6e19-4b7d-8c10-a846ed4e74a3@igalia.=
com/T/#md4284ded141876b7d7b942d2d449d6100bd20a2e
>
> It still only contains the fixes and cleanups with the render node hacks
> removed.
>
> All patches have now been reviewed, although from v1 to v2 it was a diffi=
cult
> rebase do upstream movement that happened in the meantime. So I think it =
would
> be good to smoke test it in an environemnt other than where I tested usin=
g my
> amd_criu IGT.
>
> Two patches have been dropped from the series:
>
>   plugins/amdgpu: Check images were opened successfully
>   plugins/amdgpu: Fix error handling in amdgpu_plugin_drm_restore_file()
>
> The same fixes have since been implemented in upstream at least in:
>
>   611af0188dfe ("plugin/amdgpu: add open_img_file error handling")
>   16b252ee21a8 ("plugin/amdgpu: add missing xzalloc() NULL checks in drm"=
)
>
> Fingers crossed I have not messed up anything in this relatively extensiv=
e
> rebase and ideally we can merge this sooner rather than later and carry o=
n
> working on top.

Tvrtko,

could you please review comments and ci failures:
https://github.com/checkpoint-restore/criu/pull/2999

Thanks,
Andrei