Re: [PATCH v2 00/23] Amdgpu plugin cleanups and fixes
Tvrtko Ursulin <[email protected]> Mon, 13 Apr 2026 20:47:17 +0100
| Newsgroups | dev.linux.lists.criu |
|---|---|
| Message-ID | <[email protected]> |
Hi Andrei, On 13/04/2026 19:23, Andrei Vagin wrote: > On Fri, Apr 10, 2026 at 11:55 AM Tvrtko Ursulin > <[email protected]> wrote: >> >> This series is a subset of previously posted as RFC: >> https://lore.kernel.org/criu/CAEWA0a4ghpPeQjg1ETiQysGj5agfWwJRvMbWzhrYL5r8WZ5H7Q@mail.gmail.com/T/#mfb4ab4866a0cb440961be7170d0e107fab7eedf2 >> >> And as v1 cleanups only: >> https://lore.kernel.org/criu/[email protected]/T/#md4284ded141876b7d7b942d2d449d6100bd20a2e >> >> It still only contains the fixes and cleanups with the render node hacks >> removed. >> >> All patches have now been reviewed, although from v1 to v2 it was a difficult >> rebase do upstream movement that happened in the meantime. So I think it would >> be good to smoke test it in an environemnt other than where I tested using my >> amd_criu IGT. >> >> Two patches have been dropped from the series: >> >> plugins/amdgpu: Check images were opened successfully >> plugins/amdgpu: Fix error handling in amdgpu_plugin_drm_restore_file() >> >> The same fixes have since been implemented in upstream at least in: >> >> 611af0188dfe ("plugin/amdgpu: add open_img_file error handling") >> 16b252ee21a8 ("plugin/amdgpu: add missing xzalloc() NULL checks in drm") >> >> Fingers crossed I have not messed up anything in this relatively extensive >> rebase and ideally we can merge this sooner rather than later and carry on >> working on top. > > Tvrtko, > > could you please review comments and ci failures: > https://github.com/checkpoint-restore/criu/pull/2999 Sure thing, I was not aware there is all that infra. Also, if I switch away from the mailing list workflow, presumably I can get these reports for pull requests I make? Regards, Tvrtko