Re: [PATCH v2 0/4] minio cleanup patches.

On Mon, 2026-06-15 at 19:36 -0400, Benjamin Marzinski wrote:
> This patchset is to deprecate the rr_weight, rr_min_io_rq, and
> rr_min_io
> multipath config options. It's a companion of the patchset to handle
> their deprecation in the man pages.
> https://lore.kernel.org/all/[email protected]/
> 
> It does not completely remove the minio setting code, since there are
> ideas for reusing this in the future. The final patch is simply a
> change
> to avoid a kernel warning message that I hit while testing these
> patches.

With patch 1/4 goes our only way to set path-specific weights. But it
wasn't functional anyway, so if we want to do anything of the kind
again in the future, we'll have to re-implement it in a cleaner way
than what we had until now.

For the series:
Reviewed-by: Martin Wilck <[email protected]>

> 
> Changes in V2 (due to issues pointed out by Xose Vazquez Perez):
> 0001: removed rr_weight_mode enum, default value, and
> print_rr_weight()
>       function declaration
> 0002: changed do_default() to mp_set_default()
> 0003: Removed comment mentioning the DM target version check for
>       the minio source.
> 
> Benjamin Marzinski (4):
>   libmultipath: deprecate rr_weight, and make it do nothing
>   libmultipath: deprecate rr_min_io_rq, and make it do nothing
>   libmultipath: deprecate rr_min_io
>   libmultipath: don't set hwhander for bio based devices
> 
>  libmultipath/config.c    |  6 ---
>  libmultipath/config.h    |  6 ---
>  libmultipath/configure.c |  1 -
>  libmultipath/defaults.h  |  3 +-
>  libmultipath/dict.c      | 90 +++++++-------------------------------
> --
>  libmultipath/dict.h      |  1 -
>  libmultipath/dmparser.c  | 28 +------------
>  libmultipath/hwtable.c   |  3 --
>  libmultipath/propsel.c   | 54 ++++++------------------
>  libmultipath/propsel.h   |  1 -
>  libmultipath/structs.h   |  7 ----
>  tests/hwtable.c          | 13 ++----
>  tests/test-lib.c         |  2 -
>  13 files changed, 33 insertions(+), 182 deletions(-)