Re: [PATCH] genl: fix l_genl_family_cancel to wait for NLMSG_DONE

Denis Kenzior <[email protected]> Mon, 22 May 2023 09:20:14 -0500
Newsgroups dev.linux.lists.ell
Message-ID <[email protected]>
Hi James,

On 5/18/23 11:47, James Prestwood wrote:
> If a genl request was already sent to the kernel a call to
> l_genl_family_cancel would remove it from the pending list
> immediately. This then allowed l_genl_family_send to queue
> another message before the previous/canceled message was
> completed. This is not how l_genl is intended to work.
> 
> Instead we can clean up the request immediately in
> l_genl_family_cancel but not remove it from the queue. This
> will prevent any more messages from being sent until NLMSG_DONE
> was received for the canceled message.
> ---
>   ell/genl.c | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis