Re: [PATCH] ell: Make public headers compilable with C++
Denis Kenzior <[email protected]> Mon, 22 May 2023 09:34:19 -0500
| Newsgroups | dev.linux.lists.ell |
|---|---|
| Message-ID | <[email protected]> |
Hi Brandon, No top posting on this list please. > > Thanks for pointing that out. Wouldn't it be better to not assume an > array of 6+ bytes and instead > do NULL and size checking in the implementations? > Well, 'better' is in the eyes of the beholder. Since we're primarily a C library, the guarantees that [static 6] syntax provides are 'better' since we can avoid unnecessary checking. This checking is trivial in the end, but still... This particular syntax also helps with code readability since the user is automatically provided an explicit meaning of the function arguments. I'd like to preserve the latter if there's another suitable alternative. My main point though is that your patch that just changes the signature is not enough. You have to address the implementation and ideally submit patches to iwd since you're breaking the API. Regards, -Denis