Re: [PATCH] log: add l_notice
Denis Kenzior <[email protected]> Wed, 14 Feb 2024 10:40:28 -0600
| Newsgroups | dev.linux.lists.ell |
|---|---|
| Message-ID | <[email protected]> |
Hi Marcel, On 2/14/24 10:27, Marcel Holtmann wrote: > Hi Denis, > >>>> #define L_LOG_WARNING 4 >>>> +#define L_LOG_NOTICE 5 >>>> #define L_LOG_INFO 6 >>>> #define L_LOG_DEBUG 7 >>> for what? What is the difference to just use l_info? >> >> Per conversation on Slack, James wants to categorize certain messages for easier searching. Since NOTICE level exists, I suggested it would fit the usecase. > > I never really liked having many different levels. That was the reason I left l_notice out initially. I see no real benefit of it except us discussing "is this suppose to be l_info and l_notice" and in the end it will be just random. There will always be some of that. Each project will have to calibrate individually, but I don't see a problem exposing this inside ell. In iwd we use l_info for purely informational messages, like hardware capabilities. Most users won't care. l_notice would be used for things like roaming decision logic and other messages that do not warrant a l_warn / l_error. I think it is a nice in-between actually, particularly on non-user facing systems. Regards, -Denis