Re: [Fuego] [PATCH 0/2] Migrate code to python2 and 3 compatible

"Bird, Tim" <[email protected]> Tue, 1 Feb 2022 22:24:16 +0000
Newsgroups dev.linux.lists.fuego
Message-ID <BYAPR13MB25037DAC1553FD09E3FB0B46FD269@BYAPR13MB2503.namprd13.prod.outlook.com>
Shivanand,

My deep apologies.  I don't recall seeing this patch series in December.
I checked my work e-mail, and don't see it.  However, it does appear in
a separate e-mail account that I have monitoring the Fuego list, as well as in
the Fuego mail list archives.  I'm so sorry, but I seem to have missed this
contribution.

These patches are quite interesting to me, and I shall take a closer look.

A while back I did some code conversion for python3 compatibility
in Fuego, but for some reason parts of the print() conversions never
got committed to the upstream repository. (Perhaps I did not finish
the testing of it to my satisfaction).

In any event I'll have to compare your work with mine, and see about
applying these patches, in an attempt to make Fuego more compatible
with Python3.

Thanks.
 -- Tim



> -----Original Message-----
> From: [email protected] <[email protected]>
> 
> Hi Tim,
> 
> Did you get time to check my patches related to python2 and 3 compatible changes ?
> Let me know if there are any feedback, I have few other patches in my local branch and I would like to send those patches as well.
> 
> Thanks & Regards
> Shivanand K
> 
> > -----Original Message-----
> > From: [email protected]
> > <[email protected]>
> > Sent: Wednesday, December 15, 2021 8:48 PM
> > To: [email protected]
> > Cc: kunijadar shivanand(TSIP) <Shivanand.Kunijadar@toshiba-
> > tsip.com>; [email protected]; dinesh kumar(TSIP)
> > <[email protected]>; hayashi kazuhiro(林 和宏 □SWC◯AC
> > T) <[email protected]>; pyla venkata(TSIP)
> > <[email protected]>
> > Subject: [PATCH 0/2] Migrate code to python2 and 3 compatible
> >
> > From: Shivanand Kunijadar <[email protected]>
> >
> > Hi Tim,
> >
> > I modified the code to make it compatible on both python2 and 3 versions
> > Kindly review and provide your feedback
> >
> > Shivanand Kunijadar (2):
> >   python2to3: Convert the print statement to the print() function
> >   python2to3: change dict.has_key(key) to key in dict
> >
> >  scripts/deorphan-runs.py               | 12 ++++++------
> >  scripts/functions.sh                   |  2 +-
> >  scripts/gen-page.py                    |  2 +-
> >  scripts/loggen/gentexml.py             |  2 +-
> >  scripts/loggen/loggen.py               | 12 ++++++------
> >  scripts/ovgen.py                       |  8 ++++----
> >  scripts/parser/common.py               | 20 ++++++++++----------
> >  scripts/parser/fuego_parser_results.py |  2 +-
> >  scripts/parser/fuego_parser_utils.py   |  6 +++---
> >  scripts/parser/prepare_chart_data.py   |  4 ++--
> >  tests/Functional.LTP/ltp_process.py    | 10 +++++-----
> >  tests/Functional.LTP/parser.py         | 18 +++++++++---------
> >  tests/Functional.autopkgtest/parser.py |  6 +++---
> >  13 files changed, 52 insertions(+), 52 deletions(-)
> >
> > --
> > 2.20.1
>