Re: [Fuego] [PATCH 0/2] Migrate code to python2 and 3 compatible

Shivanand,

I was able to more carefully review your patches from December.  I am happy to
report that I found them to be good, and have applied them to the fuego-core
master branch.

I did some testing, but I would be quite happy if you could pull the latest
fuego-core git repository from bitbucket and test them, to make sure that
your workflow is supported.

Also, I have added a script (in fuego-core/scripts) called check-2to3.sh
This is just a small wrapper around the '2to3' tool, and it runs 2to3
with 'ftc'.  There are a few items left in 'ftc' to support compatibility
of that tool with both Python2 and Python3.

Would you be able to take a look at the comments in the header
of check-2to3.sh, as well as review its output, and tell me if you
are available to work on some of the remaining items to make
ftc fully compatible with both python2 and python3?

Thanks very much for your contribution to Fuego.  And sorry again
that I missed your patches in December.

Thanks and regards,
 -- Tim


> -----Original Message-----
> From: Fuego <[email protected]> On Behalf Of Bird, Tim
> 
> Shivanand,
> 
> My deep apologies.  I don't recall seeing this patch series in December.
> I checked my work e-mail, and don't see it.  However, it does appear in
> a separate e-mail account that I have monitoring the Fuego list, as well as in
> the Fuego mail list archives.  I'm so sorry, but I seem to have missed this
> contribution.
> 
> These patches are quite interesting to me, and I shall take a closer look.
> 
> A while back I did some code conversion for python3 compatibility
> in Fuego, but for some reason parts of the print() conversions never
> got committed to the upstream repository. (Perhaps I did not finish
> the testing of it to my satisfaction).
> 
> In any event I'll have to compare your work with mine, and see about
> applying these patches, in an attempt to make Fuego more compatible
> with Python3.
> 
> Thanks.
>  -- Tim
> 
> 
> 
> > -----Original Message-----
> > From: [email protected] <[email protected]>
> >
> > Hi Tim,
> >
> > Did you get time to check my patches related to python2 and 3 compatible changes ?
> > Let me know if there are any feedback, I have few other patches in my local branch and I would like to send those patches as well.
> >
> > Thanks & Regards
> > Shivanand K
> >
> > > -----Original Message-----
> > > From: [email protected]
> > > <[email protected]>
> > > Sent: Wednesday, December 15, 2021 8:48 PM
> > > To: [email protected]
> > > Cc: kunijadar shivanand(ＴＳＩＰ) <Shivanand.Kunijadar@toshiba-
> > > tsip.com>; [email protected]; dinesh kumar(ＴＳＩＰ)
> > > <[email protected]>; hayashi kazuhiro(林 和宏 □ＳＷＣ◯ＡＣ
> > > Ｔ) <[email protected]>; pyla venkata(ＴＳＩＰ)
> > > <[email protected]>
> > > Subject: [PATCH 0/2] Migrate code to python2 and 3 compatible
> > >
> > > From: Shivanand Kunijadar <[email protected]>
> > >
> > > Hi Tim,
> > >
> > > I modified the code to make it compatible on both python2 and 3 versions
> > > Kindly review and provide your feedback
> > >
> > > Shivanand Kunijadar (2):
> > >   python2to3: Convert the print statement to the print() function
> > >   python2to3: change dict.has_key(key) to key in dict
> > >
> > >  scripts/deorphan-runs.py               | 12 ++++++------
> > >  scripts/functions.sh                   |  2 +-
> > >  scripts/gen-page.py                    |  2 +-
> > >  scripts/loggen/gentexml.py             |  2 +-
> > >  scripts/loggen/loggen.py               | 12 ++++++------
> > >  scripts/ovgen.py                       |  8 ++++----
> > >  scripts/parser/common.py               | 20 ++++++++++----------
> > >  scripts/parser/fuego_parser_results.py |  2 +-
> > >  scripts/parser/fuego_parser_utils.py   |  6 +++---
> > >  scripts/parser/prepare_chart_data.py   |  4 ++--
> > >  tests/Functional.LTP/ltp_process.py    | 10 +++++-----
> > >  tests/Functional.LTP/parser.py         | 18 +++++++++---------
> > >  tests/Functional.autopkgtest/parser.py |  6 +++---
> > >  13 files changed, 52 insertions(+), 52 deletions(-)
> > >
> > > --
> > > 2.20.1
> >
> 
> _______________________________________________
> Fuego mailing list
> [email protected]
> https://lists.linuxfoundation.org/mailman/listinfo/fuego