Re: [Fuego] [PATCH 1/1] fio/parser.py: Add support to parse later versions of fio 2.16

"Bird, Tim" <[email protected]> Tue, 19 Apr 2022 20:57:30 +0000
Newsgroups dev.linux.lists.fuego
Message-ID <BYAPR13MB2503C8DCB39C6E7147B3F777FDF29@BYAPR13MB2503.namprd13.prod.outlook.com>
> -----Original Message-----
> From: [email protected] <[email protected]=
m>
> > -----Original Message-----
> > From: Bird, Tim <[email protected]>
...
> >
> > I'm a little confused about how you are executing an fio version greate=
r than
> > 2.0.8, which is the one installed by fuego_test.sh.
> >
> We are using the fio from Debian package system which is fio-3.25 version=
 and that is pre-installed in the board,
> so we wanted to update the parsing logic in the fuego-core to report the =
results correctly.
>=20
> We contributing this to upstream so that it will be useful in future if t=
he fuego-core test are upgraded with later versions.
>=20
> > This test doesn't have logic that detects and uses a different version =
of the
> > 'fio' binary if it is already on the board.  Do you have other changes =
to this
> > test to go along with the parse change?
> >
> Currently we don't have any other changes, in future if we see any issue =
will share with you.
I figured you were running 'fio' from a distribution package (not the fio b=
inary built by the Fuego test).
My question was "how"?

On my system, even if I have a newer version of 'fio' installed in /usr/bin=
, Fuego
still executes /home/fuego/fuego.Benchmar.fio/fio

I missed the part of fuego_test.sh where 'get_program_path fio' is used.
Apparently in your lab, you either do not run test_deploy, or you have
modified the test_deploy() function to not put 'fio' into $BOARD_TESTDIR/fu=
ego.$TESTDIR.

That's the part I was asking about.

I was wondering if you had something like this in your Benchmark.fio/feugo_=
test.sh:test_deploy() function:
if ! cmd test -f /usr/bin/fio ; then
   put fio $BOARD_TESTDIR/fuego.$TESTDIR
fi

I'm not familiar with your mechanisms for operating on the local host as th=
e
device under test.
 -- Tim