Re: [Fuego] [PATCH 1/1] fio/parser.py: Add support to parse later versions of fio 2.16

Hi Tim,

Thanks for the prompt response and support always,

I would like know, whether there is any policy for keeping the Benchmark te=
st versions in the fuego-core,
I mean the current version of fio in fuego-core is 2.0.8, but can we upgrad=
e the version to the latest version (may be 3.30)?
Because the new versions got more details in the results, which may help us=
 to use it.
I don=1B$B!G=1B(Bt have strong reason to upgrade it to latest version, but =
it is nice to have latest version as they give more details.

As you may know, in Toshiba we were using Debian based system, so we use De=
bian versions of Benchmark tests=20
and we skip the build and deploy phases while running the fuego Benchmark t=
ests, but we had to change the parsing logic of test results
such that it had to parse old and newer version of the test results.
Can we have mechanism to choose the parser.py based on test version?=20
May be like below just an idea, need to check how feasible it is
parser_2.0.8.py
parser_3.25.py

Also, please find my inline comments in below.

Thanks,
Venkata.

>-----Original Message-----
>From: Bird, Tim <[email protected]>
>Sent: 20 April 2022 02:28
>To: nakkala sireesha(=1B$B#T#S#I#P=1B(B) <[email protected]=
m>
>Cc: [email protected]; dinesh kumar(=1B$B#T#S#I#P=1B(B)
><[email protected]>; hayashi kazuhiro(=1B$BNS=1B(B =1B$BOB9(=
=1B(B =1B$B""#S#W#C"~#A#C#T=1B(B)
><[email protected]>; pyla venkata(=1B$B#T#S#I#P=1B(B)
><[email protected]>
>Subject: RE: [PATCH 1/1] fio/parser.py: Add support to parse later version=
s of fio
>2.16
>
>> -----Original Message-----
>> From: [email protected]
>> <[email protected]>
>> > -----Original Message-----
>> > From: Bird, Tim <[email protected]>
>...
>> >
>> > I'm a little confused about how you are executing an fio version
>> > greater than 2.0.8, which is the one installed by fuego_test.sh.
>> >
>> We are using the fio from Debian package system which is fio-3.25
>> version and that is pre-installed in the board, so we wanted to update t=
he
>parsing logic in the fuego-core to report the results correctly.
>>
>> We contributing this to upstream so that it will be useful in future if =
the fuego-
>core test are upgraded with later versions.
>>
>> > This test doesn't have logic that detects and uses a different
>> > version of the 'fio' binary if it is already on the board.  Do you
>> > have other changes to this test to go along with the parse change?
>> >
>> Currently we don't have any other changes, in future if we see any issue=
 will
>share with you.
>I figured you were running 'fio' from a distribution package (not the fio =
binary
>built by the Fuego test).
>My question was "how"?
>
>On my system, even if I have a newer version of 'fio' installed in /usr/bi=
n, Fuego
>still executes /home/fuego/fuego.Benchmar.fio/fio
>
>I missed the part of fuego_test.sh where 'get_program_path fio' is used.
>Apparently in your lab, you either do not run test_deploy, or you have mod=
ified
>the test_deploy() function to not put 'fio' into
>$BOARD_TESTDIR/fuego.$TESTDIR.
>
>That's the part I was asking about.
>
>I was wondering if you had something like this in your
>Benchmark.fio/feugo_test.sh:test_deploy() function:
>if ! cmd test -f /usr/bin/fio ; then
>   put fio $BOARD_TESTDIR/fuego.$TESTDIR fi
Thanks for reminding this, we have a change similar to that to apply test c=
onfigurations present in test_deploy function.
But they are little complex to apply them in upstream, so we decided to cur=
rently keep them local, may be one day
I will make it simple and forward the patch to upstream.

>
>I'm not familiar with your mechanisms for operating on the local host as t=
he
>device under test.
> -- Tim
>