Re: [PATCH 05/14] fs: remove inode_update_time
Christoph Hellwig <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,org.infradead.lists.linux-mtd,org.kernel.vger.io-uring,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Nov 17, 2025 at 06:59:25AM +0000, Chaitanya Kulkarni wrote: > > - ret = inode_update_time(inode, sync_mode); > > + if (inode->i_op->update_time) > > + ret = inode->i_op->update_time(inode, sync_mode); > > + else > > + generic_update_time(inode, sync_mode); > > mnt_put_write_access_file(file); > > return ret; > > } > > do you need to catch the value from generic_update_time() to match > if case ? although original code was returning 0 for generic_update_time() > case : Yes. It doesn't matter for this series, but it's good future-proofing.