Re: [PATCH 10/14] fs: factor out a sync_lazytime helper
Christoph Hellwig <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,org.infradead.lists.linux-mtd,org.kernel.vger.io-uring,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Nov 17, 2025 at 07:38:29AM +0000, Chaitanya Kulkarni wrote: > > This sync_lazytime() will always return false ? > shouldn't this be returning true at sometime if not then why not > change return type to void ? > > returning same value doesn't add any value here .. Yes, it should return true when actually doing work. So currently the syncing on final inode eviction is broken, but it looks like non of the tests actually hits it.