Re: [PATCH v2 3/7] drm/panel: simple: Add waiken WKS101WX001-WCT support

On Wed, Jul 22, 2026 at 05:12:47PM -0500, Frank Li wrote:
> On Wed, Jul 22, 2026 at 11:57:09AM +0800, Liu Ying wrote:
> > On Wed, Jul 22, 2026 at 11:44:09AM +0800, Liu Ying wrote:
> > > On Tue, Jul 21, 2026 at 07:05:03PM -0500, Frank Li wrote:
> > > > On Fri, Jul 17, 2026 at 01:48:31PM +0800, Liu Ying wrote:
> > > > > On Wed, Jul 15, 2026 at 02:34:48PM -0400, [email protected] wrote:
> > > > > > From: Frank Li <[email protected]>
> > > > > >
> > > > > > Add support for WKS101WX001-WCT panel, which is an industrial-grade
> > > > > > 10.1-inch IPS TFT LCD capacitive touch screen display module.
> > > > > >
> > > > > > Signed-off-by: Frank Li <[email protected]>
> > > > > > ---
> > > > > > change in v2
> > > > > > - update height to 135 from 136 (sashiko)
> > > > > > ---
> > > > > >  drivers/gpu/drm/panel/panel-simple.c | 31 +++++++++++++++++++++++++++++++
> > > > > >  1 file changed, 31 insertions(+)
> > >
> > > [...]
> > >
> > > > > > +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> > > > >
> > > > > Seems that the panel also supports LVDS input according to the specification,
> > > > > since it mentions 'RGB or LVDS Interface'?
> > > >
> > > > Need hardware rework to use LVDS. Need remove banch of resistors. Should it
> > > > be treat as difference panel by different compatible string? hardware
> > > > actually changed.
> > >
> > > Not sure how to handle that.
> >
> > Wait, you probably may drop this patch, just document the compatible
> > string in panel-simple.yaml and panel-lvds.yaml and use add a fallback
> > compatible string "panel-dpi" or "panel-lvds" in device tree plus a
> > panel-timing node.
> 
> Look like recently prefer add panel-timing informaiton into c code instead
> of put it into dts file. But I am not sure about it. Just check recent's
> log history.

If display timing is specified in panel-simple.c, then you have to specify
the connector_type there too, right?  The problem here is that you don't
know the connector_type, as it could be either LVDS or DPI, and I'd assume
that we don't want two compatible strings - one for LVDS and the other for
DPI.  Although display timing in panel-simple.c avoids duplicated panel-timing
nodes across various potential DT files, I think you have the "good" reason
here to use the panel-timing node + fallback compatible string with one single
panel specific compatible string.

> 
> Add Neil Armstrong for comments.
> 
> Frank
> 
> >
> > --
> > Regards,
> > Liu Ying

-- 
Regards,
Liu Ying