Re: [PATCH v2 1/5] ASoC: dt-bindings: fsl,imx-asrc: update port binding to support multiple paths

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Validation fails on example code: dtc merges both asrc@2034000 nodes, triggering the mutual exclusion constraint.
--

--- Patch [1]: [PATCH v2 1/5] ASoC: dt-bindings: fsl,imx-asrc: update port binding to support multiple paths ---
commit e164bae1625f2a8ec5fb2503565d3f37194aee90
Author: Shengjiu Wang <[email protected]>

ASoC: dt-bindings: fsl,imx-asrc: update port binding to support multiple paths

The commit adds a `ports` container to support multiple independent conversion
paths for the i.MX ASRC hardware. It enforces that both the deprecated `port`
and new `ports` cannot be used at the same time, and adds a second example
demonstrating the new configuration.

> diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> --- a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
[ ... ]
> @@ -125,6 +135,10 @@ required:
>    - fsl,asrc-width
>  
>  allOf:
> +  - not:
> +      required:
> +        - port
> +        - ports
>    - $ref: dai-common.yaml#
>    - if:
>        properties:

[ ... ]

> @@ -188,3 +202,59 @@ examples:
>              };
>         };
>      };
> +
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/clock/imx6qdl-clock.h>
> +    asrc1: asrc@2034000 {

[Severity: Low]
Does this node name cause a build failure during dt_binding_check?

Because dt_binding_check concatenates all entries in the `examples` array into a
single DTS context for validation, using the same node name and unit address
(asrc@2034000) as the first example causes dtc to merge the two example nodes.

This results in a single merged node containing both the `port` property from
the first example and the `ports` property from this new example, which then
triggers the new mutual exclusion constraint (`not: required: [port, ports]`).

Would it be better to change the unit address for this second example (e.g.,
asrc@2038000) to prevent dtc from merging them?

> +        compatible = "fsl,imx53-asrc";
> +        reg = <0x02034000 0x4000>;
> +        interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&clks IMX6QDL_CLK_ASRC_IPG>,

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1