Re: [PATCH v2 5/9] arm64: dts: imx8ulp-evk: Add gpio-keys node for power button

On Mon, Jul 20, 2026 at 02:37:15PM +0000, [email protected] wrote:
>Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>- [Medium] The power button lacks the `wakeup-source` property, preventing it from waking up the system from suspend.
>--
>
>--- Patch [5]: [PATCH v2 5/9] arm64: dts: imx8ulp-evk: Add gpio-keys node for power button ---
>commit 7fed30ac7ebed8088b601492b14b387b09c09f46
>Author: Peng Fan <[email protected]>
>
>arm64: dts: imx8ulp-evk: Add gpio-keys node for power button
>
>This commit adds a gpio-keys node for the power-on button to both the
>imx8ulp-9x9-evk and imx8ulp-evk device trees. The button is mapped to
>report KEY_POWER to user space.
>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-9x9-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-9x9-evk.dts
>> index 5497e3d78136f..af8f0d6087f71 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8ulp-9x9-evk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8ulp-9x9-evk.dts
>> @@ -10,6 +10,18 @@
>>  / {
>>  	model = "NXP i.MX8ULP EVK9";
>>  	compatible = "fsl,imx8ulp-9x9-evk", "fsl,imx8ulp";
>> +
>> +	gpio-keys {
>> +		compatible = "gpio-keys";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_gpio_keys>;
>> +
>> +		button-power-on {
>> +			label = "PowerOn";
>> +			gpios = <&gpiof 11 GPIO_ACTIVE_LOW>;
>> +			linux,code = <KEY_POWER>;
>
>[Severity: Medium]
>Will this power button be able to wake the system from suspend? It looks
>like the wakeup-source property is missing from this node, which might
>prevent the button from acting as a wake source for the board.

No. this button could not work as wake source when APD in PD mode.

>
>> +		};
>> +	};
>>  };
>
>[ ... ]
>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
>> index 5dea66c1e7aa0..6a92c5ca9a412 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
>> @@ -20,6 +21,18 @@ chosen {
>>  		stdout-path = &lpuart5;
>>  	};
>>  
>> +	gpio-keys {
>> +		compatible = "gpio-keys";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_gpio_keys>;
>> +
>> +		button-power-on {
>> +			label = "PowerOn";
>> +			gpios = <&gpiof 31 GPIO_ACTIVE_LOW>;
>> +			linux,code = <KEY_POWER>;
>
>[Severity: Medium]
>Similarly here, does this button need the wakeup-source property to wake
>the board from sleep states? Without it, the GPIO interrupt for the power
>button may not be configured as a wake source when the system is suspended.

Ditto.

Regards
Peng

>
>> +		};
>> +	};
>> +
>
>-- 
>Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5