Re: [PATCH v2 3/3] arm64: dts: imx93: Add i.MX93 Wireless FRDM board support
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The device tree fails to configure the Bluetooth reset and wake pins documented in the commit message, leaving the inherited Bluetooth node broken. - [Low] The commit message contains a copy-paste error in its hardware differences table headers. -- --- Patch [3]: [PATCH v2 3/3] arm64: dts: imx93: Add i.MX93 Wireless FRDM board support --- commit 92706a692f2e24d9485918053962b1a10410a0ca Author: Joseph Guo <[email protected]> arm64: dts: imx93: Add i.MX93 Wireless FRDM board support This adds support for the i.MX93 Wireless FRDM board, reusing the imx93-11x11-frdm-common.dtsi with board-specific changes. It updates pin connections and functionality differences, mainly for WIFI/BT and I2C3. > Pin connection differences: > Function Signal name i.MX93W EVK i.MX93 EVK [Severity: Low] This isn't a bug, but there's a copy-paste error in the table headers. Should these be FRDM-IMX93W and FRDM-IMX93 instead of EVK? [ ... ] > diff --git a/arch/arm64/boot/dts/freescale/imx93w-frdm.dts b/arch/arm64/boot/dts/freescale/imx93w-frdm.dts > new file mode 100644 > index 0000000000000..766e942fe6638 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx93w-frdm.dts > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2026 NXP > + */ > + > +/dts-v1/; > + > +#include "imx93w.dtsi" > +#include "imx93-11x11-frdm-common.dtsi" > + > +/ { > + model = "NXP i.MX93W FRDM board"; > + compatible = "fsl,imx93-wireless-frdm", "fsl,imx93"; > +}; > + > +&iomuxc { > + pinctrl_lpi2c3: lpi2c3grp { > + fsl,pins = < > + MX93_PAD_GPIO_IO00__LPI2C3_SDA 0x40000b9e > + MX93_PAD_GPIO_IO01__LPI2C3_SCL 0x40000b9e > + >; > + }; > +}; [Severity: Medium] Does this board-specific device tree need to include node overrides for &bluetooth to configure the reset and wake pins documented in the commit message? The commit message notes that IND_RST_NB uses GPIO_IO28 (which was freed up by rerouting I2C3), but there is no &bluetooth node override assigning it to reset-gpios. Could this leave the inherited Bluetooth peripheral in reset and broken? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3