Re: [PATCH v1 2/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display 7" Parallel with Touch Adapter
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The standalone device tree overlay `imx7d-colibri-emmc-panel-cap-touch-7inch-parallel-touch-adapter.dtbo` is not added to the `dtb-$(CONFIG_SOC_IMX7D)` list in the Makefile, preventing it from being installed. -- --- Patch [2]: [PATCH v1 2/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display 7" Parallel with Touch Adapter --- commit b48f5641aff3d40650a9c65a6f89f2a646bc3e83 Author: Francesco Dolcini <[email protected]> ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display 7" Parallel with Touch Adapter This commit adds a device tree overlay for the Capacitive Touch Display 7" Parallel on the Colibri iMX7 parallel RGB LCD interface. It also combines this overlay with the Eval carrier board device tree to provide a ready-to-use DTB. Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-7inch-parallel/ Link: https://developer.toradex.com/hardware/accessories/add-ons/capacitive-touch-adapter/ Link: https://docs.toradex.com/104615-capacitive-touch-adapter-datasheet.pdf [1] > diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile > index 4d27300002025..3c16843c30714 100644 > --- a/arch/arm/boot/dts/nxp/imx/Makefile > +++ b/arch/arm/boot/dts/nxp/imx/Makefile [ ... ] > @@ -437,6 +441,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \ > imx7d-colibri-emmc-iris-v2.dtb \ > imx7d-colibri-emmc-iris-v2-panel-cap-touch-7inch-parallel.dtb \ > imx7d-colibri-emmc-eval-v3.dtb \ > + imx7d-colibri-emmc-eval-v3-panel-cap-touch-7inch-parallel-touch-adapter.dtb \ > imx7d-colibri-emmc-panel-cap-touch-7inch-parallel.dtbo \ [Severity: Medium] Should the standalone overlay imx7d-colibri-emmc-panel-cap-touch-7inch-parallel-touch-adapter.dtbo also be added to this dtb-$(CONFIG_SOC_IMX7D) list? Without it, the standalone overlay will not be copied to the deployment directory when running make dtbs_install, unlike the sibling overlay imx7d-colibri-emmc-panel-cap-touch-7inch-parallel.dtbo which is present just below. This might break the ability for users to apply the overlay dynamically via U-Boot on other carrier boards. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2