Re: [PATCH v1 3/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Resistive Touch Display 7" Parallel
| Newsgroups | dev.linux.lists.imx,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The standalone device tree overlay `imx7d-colibri-emmc-panel-res-touch-7inch-parallel.dtbo` is omitted from the `dtb-$(CONFIG_SOC_IMX7D)` list in the Makefile, which prevents it from being installed by `make dtbs_install`. -- --- Patch [3]: [PATCH v1 3/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Resistive Touch Display 7" Parallel --- commit 0cb2a23058bf12eef57014cc393c2263436c395f Author: Francesco Dolcini <[email protected]> ARM: dts: imx7d-colibri-emmc: Add Toradex Resistive Touch Display 7" Parallel Add a device tree overlay for the Resistive Touch Display 7" Parallel on the Colibri iMX7 parallel RGB LCD interface. The overlay is combined with the Eval carrier board device tree to provide a ready-to-use DTB. Link: https://developer.toradex.com/hardware/accessories/displays/resistive-touch-display-7inch-parallel/ > diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile > index 3c16843c30714..e9f95c3b83534 100644 > --- a/arch/arm/boot/dts/nxp/imx/Makefile > +++ b/arch/arm/boot/dts/nxp/imx/Makefile [ ... ] > @@ -442,6 +446,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \ > imx7d-colibri-emmc-iris-v2-panel-cap-touch-7inch-parallel.dtb \ > imx7d-colibri-emmc-eval-v3.dtb \ > imx7d-colibri-emmc-eval-v3-panel-cap-touch-7inch-parallel-touch-adapter.dtb \ > + imx7d-colibri-emmc-eval-v3-panel-res-touch-7inch-parallel.dtb \ [Severity: Medium] Should the standalone device tree overlay imx7d-colibri-emmc-panel-res-touch-7inch-parallel.dtbo also be added to the dtb-$(CONFIG_SOC_IMX7D) list here? It looks like omitting it prevents it from being installed by make dtbs_install, which might break the ability to dynamically load the overlay from a bootloader on other compatible carrier boards. > imx7d-colibri-emmc-panel-cap-touch-7inch-parallel.dtbo \ > imx7d-colibri-eval-v3.dtb \ > imx7d-colibri-iris.dtb \ -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3