Re: [PATCH v31 1/7] Documentation/firmware: add imx/se to other_interfaces

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch references a non-existent source file in a kernel-doc directive, which will cause documentation build failures.
--

--- Patch [1]: [PATCH v31 1/7] Documentation/firmware: add imx/se to other_interfaces ---
commit 2f907f8c1c676d8fed14e2e8d6058fd4c768cfd8
Author: Pankaj Gupta <[email protected]>

Documentation/firmware: add imx/se to other_interfaces

This commit documents the i.MX SoC Service layer and character device
driver for selected SoCs containing NXP hardware IPs for Secure Enclaves.
It details the communication protocol and layers used to interface with
these enclaves.

> diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst
> index 06ac89adaafba..6c6fa9a0ba1df 100644
> --- a/Documentation/driver-api/firmware/other_interfaces.rst
> +++ b/Documentation/driver-api/firmware/other_interfaces.rst

[ ... ]

> +When a user sends a command to the firmware, it registers its device_ctx
> +as waiter of a response from firmware.
> +
> +Enclave's Firmware owns the storage management over a Linux filesystem.
> +For this c_dev provisions a dedicated slave device called "receiver".
> +
> +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c
> +   :export:

[Severity: Low]
Does drivers/firmware/imx/se_ctrl.c exist in the tree at this point? 

It looks like this kernel-doc directive references a file that is not
included in this patch or the current source tree, which will cause the
documentation build to fail when it cannot find the specified source file.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1