Re: [PATCH v31 6/7] arm64: dts: imx8ulp: add secure enclave node

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added 'secure-enclave' node lacks the strictly required 'memory-region' property, and the referenced include file 'imx8ulp-firmware.dtsi' does not exist in the tree.
--

--- Patch [6]: [PATCH v31 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 84c95486094c423a74f2d67654a196de0232a9f8
Author: Pankaj Gupta <[email protected]>

arm64: dts: imx8ulp: add secure enclave node

Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC dtsi,
together with a label for sram@2201f000 that the node references. The node
is kept disabled by default.

>     Keep the node disabled in the SoC dtsi so it does not impose a
>     reserved-memory requirement on every board. Boards enable the enclave and
>     provide its memory-region by including imx8ulp-firmware.dtsi.

[Severity: Low]
Is imx8ulp-firmware.dtsi missing from this patch series? It doesn't appear
to exist in the tree, which might prevent boards from enabling the enclave
as instructed.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf388..38233dd74ee33 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
[ ... ]
> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +			status = "disabled";
> +		};
>  	};

[Severity: Low]
Will this node fail dtbs_check validation on boards that leave it disabled?

According to Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml,
the memory-region property is unconditionally required for this compatible
string:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - fsl,imx8ulp-se-ele-hsm
              - fsl,imx93-se-ele-hsm
    then:
      required:
        - memory-region

Even with status = "disabled", the schema expects the memory-region property
to be present in the node.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6