Re: [PATCH 11/17] arm64: dts: imx95: Add clock and sound-dai-cells properties for MQS1

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit adds `clocks` and `clock-names` properties to the common `imx95.dtsi` but fails to remove the duplicate definitions from the board-specific DTS files as claimed in the commit message.
--

--- Patch [11]: [PATCH 11/17] arm64: dts: imx95: Add clock and sound-dai-cells properties for MQS1 ---
commit d5073b98fc81da9751dc1ae974fe122948c15d30
Author: Chancel Liu <[email protected]>

arm64: dts: imx95: Add clock and sound-dai-cells properties for MQS1

This commit adds clock and sound-dai-cells properties to the MQS1 node in the
common imx95.dtsi file. It notes that these are fixed SoC integration
properties that shouldn't be duplicated across board-specific files.

> MQS1 MCLK input is driven from the respective SAI1 MCLK output, and
> sound-dai-cells describes the node as an ASoC DAI provider. Both are
> fixed SoC integration properties rather than board specific, so add them
> here in the common dtsi instead of duplicating them in each board dts.

[Severity: Low]
The commit message mentions adding these properties here "instead of
duplicating them in each board dts", but it looks like the duplicate
definitions still exist in the board files and weren't removed by this
patch.

For example, in arch/arm64/boot/dts/freescale/imx95-15x15-frdm.dts:

&mqs1 {
        clocks = <&scmi_clk IMX95_CLK_SAI1>;
        clock-names = "mclk";

And similarly in arch/arm64/boot/dts/freescale/imx95-19x19-frdm-pro.dts:

&mqs1 {
        clocks = <&scmi_clk IMX95_CLK_SAI1>;
        clock-names = "mclk";

Should this patch also remove these redundant properties from those board
files to fully consolidate them?

> diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
> index 38fc47024841f..7bc74307d9ae6 100644
> --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
> @@ -439,6 +439,9 @@ hugo_funnel_out_port0: endpoint {
>  
>  	mqs1: mqs-1 {
>  		compatible = "fsl,imx95-aonmix-mqs";
> +		clocks = <&scmi_clk IMX95_CLK_SAI1>;
> +		clock-names = "mclk";
> +		#sound-dai-cells = <0>;
>  		status = "disabled";
>  	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11