Re: [PATCH 01/17] arm64: dts: imx91_93_common: Add clock and sound-dai-cells properties for MQS

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete refactoring leaves duplicated property definitions in board files, mismatching the stated commit intent.
--

--- Patch [1]: [PATCH 01/17] arm64: dts: imx91_93_common: Add clock and sound-dai-cells properties for MQS ---
commit 3f3b7186dd0d4a7ad6f02447032fc2e5538b3ca5
Author: Chancel Liu <[email protected]>

arm64: dts: imx91_93_common: Add clock and sound-dai-cells properties for MQS

This commit adds the mclk and #sound-dai-cells properties to the mqs1 and
mqs2 nodes in the common imx91/93 dtsi. The intent is to define these fixed
SoC integration properties centrally rather than duplicating them across
individual board files.

> The "mclk" clock provides the MQS oversampling clock, and #sound-dai-cells
> describes the node as an ASoC DAI provider. Both are fixed SoC integration
> properties rather than board specific, so add them here in the common dtsi
> instead of duplicating them in each board dts.

[Severity: Medium]
The commit message mentions adding these properties here instead of
duplicating them in each board dts. Should this patch also remove the
existing duplicated properties from the board files?

It appears clocks and clock-names are still defined for the mqs1 node override
in arch/arm64/boot/dts/freescale/imx91-11x11-frdm.dts:

&mqs1 {
        clocks = <&clk IMX93_CLK_MQS1_GATE>;
        clock-names = "mclk";
...

These duplicate properties also still exist in the mqs1 node override in
arch/arm64/boot/dts/freescale/imx93-11x11-frdm.dts.

> diff --git a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> index a1a7e6a0571bd..a68ffd04ee084 100644
> --- a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> @@ -100,13 +100,19 @@ gic: interrupt-controller@48000000 {
>  
>  	mqs1: mqs1 {
>  		compatible = "fsl,imx93-mqs";
> +		clocks = <&clk IMX93_CLK_MQS1_GATE>;
> +		clock-names = "mclk";
>  		gpr = <&aonmix_ns_gpr>;
> +		#sound-dai-cells = <0>;
>  		status = "disabled";
>  	};
>  
>  	mqs2: mqs2 {
>  		compatible = "fsl,imx93-mqs";
> +		clocks = <&clk IMX93_CLK_MQS2_GATE>;
> +		clock-names = "mclk";
>  		gpr = <&wakeupmix_gpr>;
> +		#sound-dai-cells = <0>;
>  		status = "disabled";
>  	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1