Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Undocumented modification of the '&sai1' node's clock properties.
--
--- Patch [3]: [PATCH 03/17] arm64: dts: imx91-11x11-evk: Add pinmux and mark conflicting devices for MQS1 ---
commit 2ae9b14f843efe8a48368cba7c61c4f11632f83b
Author: Chancel Liu <[email protected]>
arm64: dts: imx91-11x11-evk: Add pinmux and mark conflicting devices for MQS1
This patch adds the MQS1 pinctrl group and labels the conflicting sound card
and micfil devices for the imx91-11x11-evk device tree. This allows the shared
imx9-mqs overlay to disable these conflicting devices.
> diff --git a/arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts
> index 4d1ada6a3942b..4a3dfafae3773 100644
> --- a/arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts
[ ... ]
> @@ -511,10 +511,19 @@ &micfil {
> status = "okay";
> };
>
> +&mqs1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mqs1>, <&mqs1_fun>;
> +};
> +
> &sai1 {
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&pinctrl_sai1>;
> pinctrl-1 = <&pinctrl_sai1_sleep>;
> + clocks = <&clk IMX93_CLK_SAI1_IPG>, <&clk IMX93_CLK_DUMMY>,
> + <&clk IMX93_CLK_SAI1_GATE>, <&clk IMX93_CLK_DUMMY>,
> + <&clk IMX93_CLK_DUMMY>, <&clk IMX93_CLK_AUDIO_PLL>;
> + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3", "pll8k";
[Severity: Medium]
The commit message mentions adding the MQS1 pinctrl group and labeling
conflicting devices, but doesn't mention modifying the &sai1 node's clock
properties. Is this change to the clocks and clock-names intentional for this
patch, or was it included by mistake?
If it is intended, could the commit message be updated to explain why the
pll8k clock is being added to the active SAI1 node here?
> assigned-clocks = <&clk IMX93_CLK_SAI1>;
> assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>;
> assigned-clock-rates = <12288000>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.