Re: [PATCH v36 1/7] Documentation/firmware: add imx/se to other_interfaces

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds a kernel-doc directive referencing `drivers/firmware/imx/se_ctrl.c`, which does not exist in the source tree, causing Sphinx build warnings/errors.
--

--- Patch [1]: [PATCH v36 1/7] Documentation/firmware: add imx/se to other_interfaces ---
commit 82d675982ce8a0c3aea4e77e567697a3f74c3a7b
Author: Pankaj Gupta <[email protected]>

Documentation/firmware: add imx/se to other_interfaces

Documents i.MX SoC's Service layer and C_DEV driver for selected SoC(s)
that contains the NXP hardware IP(s) for Secure Enclaves(se) like:
- NXP EdgeLock Enclave on i.MX93 & i.MX8ULP

> diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst
> index 06ac89adaafba..6c6fa9a0ba1df 100644
> --- a/Documentation/driver-api/firmware/other_interfaces.rst
> +++ b/Documentation/driver-api/firmware/other_interfaces.rst

[ ... ]

> @@ -49,3 +49,136 @@ of the requests on to a secure monitor (EL3).
>  
>  .. kernel-doc:: drivers/firmware/stratix10-svc.c
>     :export:
> +
> +NXP Secure Enclave Firmware Interface
> +=====================================

[ ... ]

> +When a user sends a command to the firmware, it registers its device_ctx
> +as waiter of a response from firmware.
> +
> +Enclave's Firmware owns the storage management over a Linux filesystem.
> +For this c_dev provisions a dedicated slave device called "receiver".
> +
> +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c
> +   :export:

[Severity: Low]
Does drivers/firmware/imx/se_ctrl.c exist in the tree yet? Referencing a
missing file in the kernel-doc directive will cause Sphinx build warnings or
errors when generating htmldocs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1