Re: [PATCH v36 6/7] arm64: dts: imx8ulp: add secure enclave node

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The 'imx8ulp-firmware.dtsi' file referenced in the commit message is missing from the patch series and the repository.
- [Medium] The 'secure-enclave' node is missing the strictly required 'memory-region' property, causing device tree validation warnings.
--

--- Patch [6]: [PATCH v36 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 76f84ac1c1605ca082a46d0943f7054948bdd267
Author: Pankaj Gupta <[email protected]>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave secure-enclave node to the i.MX8ULP
SoC dtsi. It notes that boards can enable the enclave and provide its memory
region by including imx8ulp-firmware.dtsi.

> Keep the node disabled in the SoC dtsi so it does not impose a
> reserved-memory requirement on every board. Boards enable the enclave and
> provide its memory-region by including imx8ulp-firmware.dtsi.

[Severity: Medium]
The commit message mentions that boards enable the enclave by including
imx8ulp-firmware.dtsi. Is this file missing from the patch series? 

It doesn't appear to be included in this patch or present in the repository,
which might leave the feature incomplete and unusable.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -185,6 +185,14 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;

[Severity: Medium]
Will this cause dtbs_check validation to fail for all imx8ulp boards?

The fsl,imx-se.yaml schema strictly requires the memory-region property for
the fsl,imx8ulp-se-ele-hsm compatible. Even though the node is disabled,
dt-validate still evaluates all nodes. 

Because the memory-region property is omitted here and no boards can currently
provide it due to the missing imx8ulp-firmware.dtsi, it seems this will
trigger validation warnings across all boards that include this dtsi during
make dtbs_check.

> +			status = "disabled";
> +		};
>  	};
>  
>  	cm33: remoteproc-cm33 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6