Re: [PATCH v2 22/37] gen_hosts: Add [service] group to the builder host template
Daniel Gomez <[email protected]>
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Organization | kernel.org |
| Message-ID | <[email protected]> |
On 02/09/2025 21.47, Chuck Lever wrote: > On 9/2/25 3:43 PM, Daniel Gomez wrote: >> On 02/09/2025 15.54, Chuck Lever wrote: >>> From: Chuck Lever <[email protected]> >>> >>> Ensure that the [service] group is defined in the builder >>> node's host template, to quash some noisy warnings during >>> bringup. >>> >>> Reviewed-by: Luis Chamberlain <[email protected]> >>> Signed-off-by: Chuck Lever <[email protected]> >> >> I wonder if we should apply this to other templates too? >> >> We have service group declared for fio-tests, fstests, gitr, hosts, nfstest >> and pynfs. I'll try to remember when running other workflows! >> >> Reviewed-by: Daniel Gomez <[email protected]> >> > > I didn't want to just scatter-shot this change, was waiting to see > actual warnings come up. But I think it's likely that the builder > template is not the only one that might need [service]. Patch 33 actually adds the service group to the remaining templates. I just saw it later :) Nit: I think both can be squashed. > >