Re: [PATCH v2 23/37] guestfs: Don't run the 'destroy' tags on the controller

On 02/09/2025 21.59, Chuck Lever wrote:
> On 9/2/25 3:54 PM, Daniel Gomez wrote:
>> On 02/09/2025 15.54, Chuck Lever wrote:
>>> From: Chuck Lever <[email protected]>
>>>
>>> "make destroy" was skipping some important file removals, and
>>> removing other files that do not exist.
>>>
>>> Reviewed-by: Luis Chamberlain <[email protected]>
>>> Signed-off-by: Chuck Lever <[email protected]>
>>> ---
>>>  scripts/guestfs.Makefile | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/scripts/guestfs.Makefile b/scripts/guestfs.Makefile
>>> index f6c350a43f27..953c61493a88 100644
>>> --- a/scripts/guestfs.Makefile
>>> +++ b/scripts/guestfs.Makefile
>>> @@ -96,6 +96,7 @@ PHONY += status_guestfs
>>>  
>>>  destroy_guestfs:
>>>  	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
>>> +		--limit 'baseline:dev:service' \
>>
>> Do we need to be explicit here?
>>
>> The guestfs.yml playbook already defines hosts: all. Not sure if I understand
>> the reason why things were skipped. Can you elaborate?
> 
> Before, the "destroy" inventory would have generated these tasks:
> 
> host1 -> localhost
> host2 -> localhost
> host3 -> localhost
> 
> But [all] now includes localhost. So we get:
> 
> host1 -> localhost
> host2 -> localhost
> host3 -> localhost
> localhost -> localhost
> 
> It's that last item that is unwanted.

Got it. I think I was confused by the commit message but makes sense now.

Reviewed-by: Daniel Gomez <[email protected]>

> 
> 
>>> 		playbooks/guestfs.yml \
>>>  		--extra-vars=@./extra_vars.yaml \
>>>  		--tags destroy
> 
>