Re: [PATCH v3 32/36] devconfig: include the "service" group in the playbooks hosts list

Daniel Gomez <[email protected]>
Newsgroups dev.linux.lists.kdevops
Organization kernel.org
Message-ID <[email protected]>
On 04/09/2025 17.15, Chuck Lever wrote:
> From: Chuck Lever <[email protected]>
> 
> Since commit 1cf0800c9ffc ("gen_hosts: templates: include localhost
> in the all group"), the devconfig playbook is no longer updating the
> nfsd service host.
> 
> 1. Actually all the service hosts need to be updated by devconfig,
>    so ensure devconfig runs against the service group.
> 
> 2. Since devconfig can run against most workflows, add blank
>    [service] groups to any inventory template that doesn't already
>    have it.
> 
> Fixes: 1cf0800c9ffc ("gen_hosts: templates: include localhost in the all group")
> Reviewed-by: Luis Chamberlain <[email protected]>
> Signed-off-by: Chuck Lever <[email protected]>


We have other users of devconfig.yml in scripts/journal-server.Makefile and
scripts/kotd.Makefile that make use of --limit appropriately with the new
changes.

LGTM,

Reviewed-by: Daniel Gomez <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.