[PATCH 00/10] Bisectable Ansible-Lint Fixes - 2nd edition
Daniel Gomez <[email protected]>
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
1st edition: https://lore.kernel.org/kdevops/[email protected]/ Here are more Ansible lint fixes provided by a downstream script [1] that automatically applies individual lint rules and commits them. As a side note, the script [2] may be ready to upstream. It combines the scripts/fix_ansible_lint.py (manual fixes) from Luis including some fixes found. The script also has support for an ansible-lint wrapper (autofixer): ./scripts/ansible-lint-comprehensive-fixer.py \ --fix-with-ansible-lint \ --fix-with-custom-rules \ --auto The branch contains notes of the fixes and features. We may want to upstream the script at some point for CI purposes and avoid introducing fixable lint issues in the future. Link: https://github.com/dkruces/kdevops/tree/dagomez/ansible-lint-comprehensive-fixer [1] Link: https://lore.kernel.org/kdevops/[email protected]/ [2] Signed-off-by: Daniel Gomez <[email protected]> --- Daniel Gomez (10): devconfig: prevent ansible-lint no-free-form milvus: fix YAML syntax error in benchmark_setup.yml playbooks: ansible-lint fix yaml playbooks: ansible-lint fix command-instead-of-shell playbooks: ansible-lint fix fqcn playbooks: ansible-lint fix name playbooks: ansible-lint fix key-order playbooks: ansible-lint fix jinja playbooks: ansible-lint fix jinja[spacing] playbooks: ansible-lint fix fqcn[action-core] playbooks/ai.yml | 2 +- playbooks/ai_benchmark.yml | 2 +- playbooks/ai_destroy.yml | 4 +- playbooks/ai_install.yml | 6 +- playbooks/ai_multifs.yml | 6 +- playbooks/ai_results.yml | 2 +- playbooks/ai_setup.yml | 2 +- playbooks/ai_tests.yml | 6 +- playbooks/ai_uninstall.yml | 2 +- playbooks/minio.yml | 10 +-- playbooks/mmtests-compare.yml | 2 +- playbooks/nixos.yml | 36 ++++----- playbooks/roles/ai_collect_results/tasks/main.yml | 28 +++---- playbooks/roles/ai_destroy/tasks/main.yml | 8 +- playbooks/roles/ai_docker_storage/tasks/main.yml | 56 ++++++------- playbooks/roles/ai_install/tasks/main.yml | 14 ++-- playbooks/roles/ai_milvus_storage/tasks/main.yml | 56 ++++++------- .../ai_multifs_run/tasks/generate_comparison.yml | 8 +- playbooks/roles/ai_multifs_run/tasks/main.yml | 10 +-- .../ai_multifs_run/tasks/run_single_filesystem.yml | 42 +++++----- playbooks/roles/ai_multifs_setup/tasks/main.yml | 30 +++---- playbooks/roles/ai_results/tasks/main.yml | 2 +- playbooks/roles/ai_run_benchmarks/tasks/main.yml | 14 ++-- playbooks/roles/ai_setup/tasks/main.yml | 8 +- playbooks/roles/ai_uninstall/tasks/main.yml | 12 +-- playbooks/roles/base_image/tasks/custom-image.yml | 1 - .../roles/blktests/tasks/install-deps/main.yml | 6 +- playbooks/roles/bootlinux/tasks/main.yml | 2 +- .../roles/bootlinux/tasks/update-grub/install.yml | 4 +- .../roles/bootlinux/tasks/update-grub/main.yml | 6 +- .../roles/btrfs_progs/tasks/install-deps/main.yml | 6 +- playbooks/roles/btrfs_progs/tasks/main.yml | 4 +- .../roles/build_qemu/tasks/install-deps/main.yml | 6 +- playbooks/roles/common/tasks/main.yml | 8 +- .../compile_dbench/tasks/install-deps/main.yml | 2 +- .../create_partition/tasks/install-deps/main.yml | 6 +- playbooks/roles/cxl/tasks/install-deps/main.yml | 6 +- playbooks/roles/devconfig/tasks/main.yml | 18 ++--- .../fstests/tasks/install-deps/debian/main.yml | 2 +- .../roles/fstests/tasks/install-deps/main.yml | 6 +- .../fstests/tasks/install-deps/redhat/main.yml | 2 +- playbooks/roles/fstests/tasks/main.yml | 12 +-- .../tasks/install-deps/main.yml | 6 +- playbooks/roles/gen_hosts/tasks/main.yml | 14 ++-- playbooks/roles/gen_nodes/tasks/main.yml | 57 ++++++-------- playbooks/roles/gitr/tasks/main.yml | 8 +- playbooks/roles/guestfs/tasks/bringup/main.yml | 5 +- .../tasks/install-deps/main.yml | 6 +- .../tasks/install-deps/main.yml | 6 +- .../tasks/install-deps/main.yml | 6 +- .../install_terraform/tasks/install-deps/main.yml | 6 +- playbooks/roles/kdc/tasks/main.yml | 4 +- playbooks/roles/ktls/tasks/install-deps/main.yml | 6 +- .../libvirt_user/tasks/enable-user/debian/main.yml | 2 +- .../libvirt_user/tasks/enable-user/redhat/main.yml | 2 +- .../libvirt_user/tasks/enable-user/suse/main.yml | 2 +- .../roles/libvirt_user/tasks/install-deps/main.yml | 6 +- playbooks/roles/linux-mirror/tasks/main.yml | 2 +- playbooks/roles/milvus/defaults/main.yml | 2 +- playbooks/roles/milvus/tasks/benchmark.yml | 8 +- playbooks/roles/milvus/tasks/benchmark_setup.yml | 7 +- playbooks/roles/milvus/tasks/install_docker.yml | 4 +- playbooks/roles/milvus/tasks/main.yml | 16 ++-- playbooks/roles/milvus/tasks/setup.yml | 6 +- playbooks/roles/minio_destroy/tasks/main.yml | 14 ++-- playbooks/roles/minio_install/tasks/main.yml | 38 ++++----- playbooks/roles/minio_results/tasks/main.yml | 14 ++-- playbooks/roles/minio_setup/tasks/main.yml | 23 +++--- playbooks/roles/minio_uninstall/tasks/main.yml | 8 +- playbooks/roles/minio_warp_run/tasks/main.yml | 92 +++++++++++----------- .../roles/mmtests/tasks/install-deps/main.yml | 6 +- playbooks/roles/mmtests_compare/tasks/main.yml | 34 ++++---- playbooks/roles/monitoring/tasks/monitor_run.yml | 2 +- .../roles/nfsd/tasks/install-deps/debian/main.yml | 2 +- .../roles/nfsd/tasks/install-deps/suse/main.yml | 2 +- playbooks/roles/nix-cache-mirror/handlers/main.yml | 4 +- playbooks/roles/pkg/tasks/main.yml | 2 +- playbooks/roles/pynfs/tasks/install-deps/main.yml | 6 +- .../roles/reboot-limit/tasks/install-deps/main.yml | 6 +- playbooks/roles/reboot-limit/tasks/main.yml | 22 +++--- .../roles/selftests/tasks/install-deps/main.yml | 6 +- playbooks/roles/selftests/tasks/main.yml | 6 +- playbooks/roles/smbd/tasks/main.yml | 2 +- playbooks/roles/steady_state/tasks/main.yaml | 24 +++--- .../sysbench/tasks/install-deps/debian/main.yml | 10 +-- .../roles/sysbench/tasks/install-deps/main.yml | 6 +- .../roles/sysbench/tasks/mysql-docker/main.yaml | 70 ++++++++-------- 87 files changed, 515 insertions(+), 530 deletions(-) --- base-commit: 533be4c716d177cfa0d4592c975647114fb83ce3 change-id: 20250905-ansible-lint-fixes-bb31f819c31c Best regards, -- Daniel Gomez <[email protected]>