[PATCH 03/10] playbooks: ansible-lint fix yaml
Daniel Gomez <[email protected]>
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
From: Daniel Gomez <[email protected]> Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]> --- playbooks/ai.yml | 2 +- playbooks/ai_benchmark.yml | 2 +- playbooks/ai_destroy.yml | 4 +-- playbooks/ai_install.yml | 6 ++-- playbooks/ai_multifs.yml | 4 +-- playbooks/ai_results.yml | 2 +- playbooks/ai_setup.yml | 2 +- playbooks/ai_tests.yml | 6 ++-- playbooks/ai_uninstall.yml | 2 +- playbooks/minio.yml | 10 +++--- playbooks/nixos.yml | 22 ++++++------ playbooks/roles/ai_collect_results/tasks/main.yml | 28 ++++++++-------- playbooks/roles/ai_destroy/tasks/main.yml | 8 ++--- playbooks/roles/ai_docker_storage/tasks/main.yml | 26 +++++++-------- playbooks/roles/ai_install/tasks/main.yml | 10 +++--- playbooks/roles/ai_milvus_storage/tasks/main.yml | 22 ++++++------ .../ai_multifs_run/tasks/generate_comparison.yml | 2 +- playbooks/roles/ai_multifs_run/tasks/main.yml | 2 +- .../ai_multifs_run/tasks/run_single_filesystem.yml | 14 ++++---- playbooks/roles/ai_multifs_setup/tasks/main.yml | 10 +++--- playbooks/roles/ai_results/tasks/main.yml | 2 +- playbooks/roles/ai_run_benchmarks/tasks/main.yml | 12 +++---- playbooks/roles/ai_setup/tasks/main.yml | 6 ++-- playbooks/roles/ai_uninstall/tasks/main.yml | 12 +++---- playbooks/roles/base_image/tasks/custom-image.yml | 1 - playbooks/roles/gen_hosts/tasks/main.yml | 8 ++--- playbooks/roles/gen_nodes/tasks/main.yml | 39 ++++++++-------------- playbooks/roles/guestfs/tasks/bringup/main.yml | 3 +- playbooks/roles/milvus/defaults/main.yml | 2 +- playbooks/roles/milvus/tasks/benchmark.yml | 6 ++-- playbooks/roles/milvus/tasks/benchmark_setup.yml | 6 ++-- playbooks/roles/milvus/tasks/install_docker.yml | 4 +-- playbooks/roles/milvus/tasks/main.yml | 12 +++---- playbooks/roles/milvus/tasks/setup.yml | 6 ++-- playbooks/roles/minio_destroy/tasks/main.yml | 6 ++-- playbooks/roles/minio_install/tasks/main.yml | 22 ++++++------ playbooks/roles/minio_results/tasks/main.yml | 4 +-- playbooks/roles/minio_setup/tasks/main.yml | 7 ++-- playbooks/roles/minio_uninstall/tasks/main.yml | 4 +-- playbooks/roles/minio_warp_run/tasks/main.yml | 29 ++++++++-------- 40 files changed, 181 insertions(+), 194 deletions(-) diff --git a/playbooks/ai.yml b/playbooks/ai.yml index b1613309..d544de7f 100644 --- a/playbooks/ai.yml +++ b/playbooks/ai.yml @@ -5,7 +5,7 @@ - name: AI Workflow - Vector Database Setup ansible.builtin.import_playbook: ai_install.yml when: ai_workflow_vector_db | default(true) | bool - tags: ['ai', 'setup'] + tags: ["ai", "setup"] # Benchmarks are run separately via make ai-tests targets # They should not run during the setup phase (make ai) diff --git a/playbooks/ai_benchmark.yml b/playbooks/ai_benchmark.yml index 85fc117c..7b2b62ca 100644 --- a/playbooks/ai_benchmark.yml +++ b/playbooks/ai_benchmark.yml @@ -5,4 +5,4 @@ ai_vector_db_milvus_benchmark_enable: true roles: - role: milvus - tags: ['ai', 'vector_db', 'milvus', 'benchmark'] + tags: ["ai", "vector_db", "milvus", "benchmark"] diff --git a/playbooks/ai_destroy.yml b/playbooks/ai_destroy.yml index eef07b2a..72e587e8 100644 --- a/playbooks/ai_destroy.yml +++ b/playbooks/ai_destroy.yml @@ -9,7 +9,7 @@ state: absent when: ai_vector_db_milvus_docker | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Remove Milvus data directories ansible.builtin.file: @@ -21,4 +21,4 @@ - "{{ ai_vector_db_milvus_log_dir }}" when: ai_vector_db_force_destroy | default(false) | bool - tags: ['ai', 'vector_db', 'milvus', 'destroy'] + tags: ["ai", "vector_db", "milvus", "destroy"] diff --git a/playbooks/ai_install.yml b/playbooks/ai_install.yml index 38e6671c..03ea7ffc 100644 --- a/playbooks/ai_install.yml +++ b/playbooks/ai_install.yml @@ -6,9 +6,9 @@ roles: - role: ai_docker_storage when: ai_docker_storage_enable | default(true) - tags: ['ai', 'docker', 'storage'] + tags: ["ai", "docker", "storage"] - role: ai_milvus_storage when: ai_milvus_storage_enable | default(false) - tags: ['ai', 'milvus', 'storage'] + tags: ["ai", "milvus", "storage"] - role: milvus - tags: ['ai', 'vector_db', 'milvus', 'install'] + tags: ["ai", "vector_db", "milvus", "install"] diff --git a/playbooks/ai_multifs.yml b/playbooks/ai_multifs.yml index 637f11f4..f1bedc1f 100644 --- a/playbooks/ai_multifs.yml +++ b/playbooks/ai_multifs.yml @@ -1,7 +1,7 @@ --- - hosts: baseline - become: yes - gather_facts: yes + become: true + gather_facts: true vars: ai_benchmark_results_dir: "{{ ai_multifs_results_dir | default('/data/ai-multifs-benchmark') }}" roles: diff --git a/playbooks/ai_results.yml b/playbooks/ai_results.yml index 881295eb..9960c35f 100644 --- a/playbooks/ai_results.yml +++ b/playbooks/ai_results.yml @@ -3,4 +3,4 @@ hosts: ai roles: - ai_collect_results - tags: ['ai', 'ai_results'] + tags: ["ai", "ai_results"] diff --git a/playbooks/ai_setup.yml b/playbooks/ai_setup.yml index f0007ee2..1efdbeaf 100644 --- a/playbooks/ai_setup.yml +++ b/playbooks/ai_setup.yml @@ -3,4 +3,4 @@ hosts: ai roles: - ai_setup - tags: ['ai', 'ai_setup'] + tags: ["ai", "ai_setup"] diff --git a/playbooks/ai_tests.yml b/playbooks/ai_tests.yml index 1a5638fc..3dac020d 100644 --- a/playbooks/ai_tests.yml +++ b/playbooks/ai_tests.yml @@ -9,7 +9,7 @@ roles: - role: milvus when: ai_vector_db_milvus | default(false) | bool - tags: ['ai', 'milvus', 'setup'] + tags: ["ai", "milvus", "setup"] - name: AI Tests - Vector Database Benchmarks hosts: ai @@ -20,7 +20,7 @@ roles: - role: ai_run_benchmarks when: ai_vector_db_milvus | default(false) | bool - tags: ['ai', 'benchmark'] + tags: ["ai", "benchmark"] - name: AI Tests - Results Collection hosts: ai @@ -28,4 +28,4 @@ roles: - role: ai_collect_results when: ai_collect_results | default(true) | bool - tags: ['ai', 'results'] + tags: ["ai", "results"] diff --git a/playbooks/ai_uninstall.yml b/playbooks/ai_uninstall.yml index fb537664..33e72b84 100644 --- a/playbooks/ai_uninstall.yml +++ b/playbooks/ai_uninstall.yml @@ -3,4 +3,4 @@ hosts: ai roles: - ai_uninstall - tags: ['ai', 'ai_uninstall'] + tags: ["ai", "ai_uninstall"] diff --git a/playbooks/minio.yml b/playbooks/minio.yml index bf80bbf4..b01818d4 100644 --- a/playbooks/minio.yml +++ b/playbooks/minio.yml @@ -5,7 +5,7 @@ hosts: minio become: true become_user: root - tags: ['minio_install'] + tags: ["minio_install"] roles: - role: minio_install - role: minio_setup @@ -24,7 +24,7 @@ hosts: minio become: true become_user: root - tags: ['minio_warp'] + tags: ["minio_warp"] roles: - role: minio_warp_run @@ -32,7 +32,7 @@ hosts: minio become: true become_user: root - tags: ['minio_uninstall'] + tags: ["minio_uninstall"] roles: - role: minio_uninstall @@ -40,7 +40,7 @@ hosts: minio become: true become_user: root - tags: ['minio_destroy'] + tags: ["minio_destroy"] roles: - role: minio_destroy @@ -48,6 +48,6 @@ hosts: minio become: true become_user: root - tags: ['minio_results'] + tags: ["minio_results"] roles: - role: minio_results diff --git a/playbooks/nixos.yml b/playbooks/nixos.yml index bdc9b1e8..66afac4f 100644 --- a/playbooks/nixos.yml +++ b/playbooks/nixos.yml @@ -10,7 +10,7 @@ ansible.builtin.command: which nix register: nix_check # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition changed_when: false - name: Install nix package manager @@ -21,7 +21,7 @@ ansible.builtin.get_url: url: https://nixos.org/nix/install dest: /tmp/install-nix.sh - mode: '0755' + mode: "0755" - name: Install nix ansible.builtin.shell: | @@ -61,7 +61,7 @@ ansible.builtin.file: path: "{{ item }}" state: directory - mode: '0755' + mode: "0755" loop: - "{{ nixos_config_dir }}" - "{{ nixos_generation_dir }}" @@ -114,19 +114,19 @@ ansible.builtin.template: src: nixos/configuration.nix.j2 dest: "{{ nixos_generation_dir }}/configuration.nix" - mode: '0644' + mode: "0644" - name: Template hardware configuration ansible.builtin.template: src: nixos/hardware-configuration.nix.j2 dest: "{{ nixos_generation_dir }}/hardware-configuration.nix" - mode: '0644' + mode: "0644" - name: Generate workflow dependencies configuration ansible.builtin.template: src: nixos/workflow-deps.nix.j2 dest: "{{ nixos_generation_dir }}/workflow-deps.nix" - mode: '0644' + mode: "0644" when: nixos_enable_workflow_deps | bool - name: Debug SSH key path @@ -137,13 +137,13 @@ ansible.builtin.template: src: nixos/vms.nix.j2 dest: "{{ nixos_generation_dir }}/vms.nix" - mode: '0644' + mode: "0644" - name: Generate flake.nix if enabled ansible.builtin.template: src: nixos/flake.nix.j2 dest: "{{ nixos_config_dir }}/flake.nix" - mode: '0644' + mode: "0644" when: nixos_use_flakes | bool # The setup phase is integrated into generate-configs to ensure SSH keys are available @@ -303,7 +303,7 @@ ansible.builtin.template: src: nixos/run-vm-wrapper.sh.j2 dest: "{{ nixos_storage_dir }}/run-{{ item }}-wrapper.sh" - mode: '0755' + mode: "0755" loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}" loop_control: index_var: vm_idx @@ -475,7 +475,7 @@ ansible.builtin.command: "{{ nixos_storage_dir }}/run-{{ item }}-wrapper.sh stop" loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}" # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Remove SSH config entries for NixOS VMs ansible.builtin.command: | @@ -490,7 +490,7 @@ loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}" when: nixos_update_ssh_config | default(true) | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Remove VM disk images ansible.builtin.file: diff --git a/playbooks/roles/ai_collect_results/tasks/main.yml b/playbooks/roles/ai_collect_results/tasks/main.yml index 9586890a..5e82f797 100644 --- a/playbooks/roles/ai_collect_results/tasks/main.yml +++ b/playbooks/roles/ai_collect_results/tasks/main.yml @@ -2,7 +2,7 @@ - name: Import optional extra_args file ansible.builtin.include_vars: "{{ item }}" # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition with_items: - "../extra_vars.yaml" tags: vars @@ -18,7 +18,7 @@ ansible.builtin.file: path: "{{ item }}" state: directory - mode: '0755' + mode: "0755" loop: - "{{ local_results_dir }}" - "{{ local_scripts_dir }}" @@ -29,15 +29,15 @@ ansible.builtin.file: path: "{{ ai_benchmark_results_dir }}/analysis" state: directory - mode: '0755' + mode: "0755" become: true - name: Copy analysis scripts to scripts directory ansible.builtin.copy: src: "{{ item }}" dest: "{{ local_scripts_dir }}/{{ item }}" - mode: '0755' - force: yes + mode: "0755" + force: true loop: - analyze_results.py - generate_graphs.py @@ -50,7 +50,7 @@ ansible.builtin.template: src: analysis_config.json.j2 dest: "{{ local_scripts_dir }}/analysis_config.json" - mode: '0644' + mode: "0644" run_once: true delegate_to: localhost when: ai_benchmark_enable_graphing | bool @@ -82,7 +82,7 @@ ansible.builtin.file: path: "{{ local_results_dir }}" state: directory - mode: '0755' + mode: "0755" run_once: true delegate_to: localhost become: false @@ -95,7 +95,7 @@ src: "{{ item.path }}" dest: "{{ local_results_dir }}/{{ item.path | basename }}" flat: true - mode: '0644' + mode: "0644" loop: "{{ remote_results.files | default([]) }}" when: - results_dir_check.stat.exists @@ -123,12 +123,12 @@ path: "{{ local_results_dir }}" owner: "{{ lookup('env', 'USER') }}" group: "{{ lookup('env', 'USER') }}" - mode: '0755' + mode: "0755" recurse: true run_once: true delegate_to: localhost become: true - tags: ['results', 'analysis'] + tags: ["results", "analysis"] - name: Run results analysis ansible.builtin.command: > @@ -140,7 +140,7 @@ run_once: true delegate_to: localhost when: collected_results.files is defined and collected_results.files | length > 0 - tags: ['results', 'analysis'] + tags: ["results", "analysis"] failed_when: analysis_result.rc != 0 - name: Display analysis script output @@ -149,20 +149,20 @@ run_once: true delegate_to: localhost when: collected_results.files is defined and collected_results.files | length > 0 - tags: ['results', 'analysis'] + tags: ["results", "analysis"] - name: Create graphs directory ansible.builtin.file: path: "{{ local_results_dir }}/graphs" state: directory - mode: '0755' + mode: "0755" run_once: true delegate_to: localhost when: - collected_results.files is defined - collected_results.files | length > 0 - tags: ['results', 'graphs'] + tags: ["results", "graphs"] # Graph generation is now handled by analyze_results.py above # No separate graph generation step needed diff --git a/playbooks/roles/ai_destroy/tasks/main.yml b/playbooks/roles/ai_destroy/tasks/main.yml index 29406b37..962b21db 100644 --- a/playbooks/roles/ai_destroy/tasks/main.yml +++ b/playbooks/roles/ai_destroy/tasks/main.yml @@ -2,7 +2,7 @@ - name: Import optional extra_args file ansible.builtin.include_vars: "{{ item }}" # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition with_items: - "../extra_vars.yaml" tags: vars @@ -17,7 +17,7 @@ - "{{ ai_etcd_container_name }}" when: ai_milvus_docker | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Remove Docker network community.docker.docker_network: @@ -25,7 +25,7 @@ state: absent when: ai_milvus_docker | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Remove Docker storage directories ansible.builtin.file: @@ -54,7 +54,7 @@ - "{{ ai_minio_container_image_string }}" when: ai_milvus_docker | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Display destroy completion message ansible.builtin.debug: diff --git a/playbooks/roles/ai_docker_storage/tasks/main.yml b/playbooks/roles/ai_docker_storage/tasks/main.yml index 612df3cb..e96b8a2f 100644 --- a/playbooks/roles/ai_docker_storage/tasks/main.yml +++ b/playbooks/roles/ai_docker_storage/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -17,7 +17,7 @@ - btrfs-progs - rsync state: present - become: yes + become: true become_method: sudo - name: Check if device exists @@ -39,8 +39,8 @@ file: path: "{{ ai_docker_mount_point }}" state: directory - mode: '0755' - become: yes + mode: "0755" + become: true become_method: sudo - name: Format device with XFS @@ -51,19 +51,19 @@ {{ ai_docker_xfs_mkfs_opts | default('') }} {{ ai_docker_device }} when: ai_docker_fstype == "xfs" - become: yes + become: true become_method: sudo - name: Format device with Btrfs command: mkfs.btrfs {{ ai_docker_btrfs_mkfs_opts }} {{ ai_docker_device }} when: ai_docker_fstype == "btrfs" - become: yes + become: true become_method: sudo - name: Format device with ext4 command: mkfs.ext4 {{ ai_docker_ext4_mkfs_opts }} {{ ai_docker_device }} when: ai_docker_fstype == "ext4" - become: yes + become: true become_method: sudo - name: Mount Docker storage filesystem @@ -73,7 +73,7 @@ fstype: "{{ ai_docker_fstype }}" opts: defaults,noatime state: mounted - become: yes + become: true become_method: sudo - name: Add Docker storage mount to fstab @@ -83,7 +83,7 @@ fstype: "{{ ai_docker_fstype }}" opts: defaults,noatime state: present - become: yes + become: true become_method: sudo - name: Check if Docker service exists @@ -97,10 +97,10 @@ systemd: name: docker state: stopped - become: yes + become: true become_method: sudo when: docker_service_status.status is defined and docker_service_status.status.ActiveState == 'active' - ignore_errors: yes + ignore_errors: true # Note: When ai_docker_storage_enable is true, we mount directly to /var/lib/docker # No need to move data or create symlinks as the storage is already in the right place @@ -109,10 +109,10 @@ file: path: "{{ ai_docker_mount_point }}" state: directory - mode: '0711' + mode: "0711" owner: root group: root - become: yes + become: true become_method: sudo when: ai_docker_mount_point == '/var/lib/docker' diff --git a/playbooks/roles/ai_install/tasks/main.yml b/playbooks/roles/ai_install/tasks/main.yml index 820e0f64..96cc17b4 100644 --- a/playbooks/roles/ai_install/tasks/main.yml +++ b/playbooks/roles/ai_install/tasks/main.yml @@ -2,7 +2,7 @@ - name: Include role create_data_partition include_role: name: create_data_partition - tags: ['setup', 'data_partition'] + tags: ["setup", "data_partition"] - name: Include role common include_role: @@ -11,7 +11,7 @@ - infer_uid_and_group|bool - name: Ensure data_dir has correct ownership - tags: ['setup'] + tags: ["setup"] become: true # become_method: sudo # sudo is the default, not needed ansible.builtin.file: @@ -20,12 +20,12 @@ group: "{{ data_group }}" recurse: true state: directory - mode: '0755' + mode: "0755" - name: Import optional extra_args file ansible.builtin.include_vars: "{{ item }}" # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition with_items: - "../extra_vars.yaml" tags: vars @@ -86,5 +86,5 @@ ansible.builtin.file: path: "{{ ai_benchmark_results_dir }}" state: directory - mode: '0755' + mode: "0755" become: true diff --git a/playbooks/roles/ai_milvus_storage/tasks/main.yml b/playbooks/roles/ai_milvus_storage/tasks/main.yml index f8e4ea63..7fb85393 100644 --- a/playbooks/roles/ai_milvus_storage/tasks/main.yml +++ b/playbooks/roles/ai_milvus_storage/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -16,7 +16,7 @@ - e2fsprogs - btrfs-progs state: present - become: yes + become: true become_method: sudo - name: Check if device exists @@ -38,8 +38,8 @@ file: path: "{{ ai_milvus_mount_point }}" state: directory - mode: '0755' - become: yes + mode: "0755" + become: true become_method: sudo - name: Detect filesystem type from node name @@ -106,19 +106,19 @@ {{ ai_milvus_xfs_mkfs_opts | default('') }} {{ ai_milvus_device }} when: milvus_fstype == "xfs" - become: yes + become: true become_method: sudo - name: Format device with Btrfs command: mkfs.btrfs {{ ai_milvus_btrfs_mkfs_opts | default('-f') }} {{ ai_milvus_device }} when: milvus_fstype == "btrfs" - become: yes + become: true become_method: sudo - name: Format device with ext4 command: mkfs.ext4 {{ milvus_ext4_opts | default(ai_milvus_ext4_mkfs_opts | default('-F')) }} {{ ai_milvus_device }} when: milvus_fstype == "ext4" - become: yes + become: true become_method: sudo - name: Mount Milvus storage filesystem @@ -128,7 +128,7 @@ fstype: "{{ milvus_fstype }}" opts: defaults,noatime state: mounted - become: yes + become: true become_method: sudo - name: Add Milvus storage mount to fstab @@ -138,17 +138,17 @@ fstype: "{{ milvus_fstype }}" opts: defaults,noatime state: present - become: yes + become: true become_method: sudo - name: Ensure Milvus directories exist with proper permissions file: path: "{{ item }}" state: directory - mode: '0755' + mode: "0755" owner: root group: root - become: yes + become: true become_method: sudo loop: - "{{ ai_milvus_mount_point }}" diff --git a/playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml b/playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml index b4453b81..2416f393 100644 --- a/playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml +++ b/playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml @@ -265,7 +265,7 @@ if __name__ == "__main__": sys.exit(main()) dest: "{{ ai_multifs_results_dir }}/generate_comparison.py" - mode: '0755' + mode: "0755" - name: Run multi-filesystem comparison analysis command: python3 {{ ai_multifs_results_dir }}/generate_comparison.py diff --git a/playbooks/roles/ai_multifs_run/tasks/main.yml b/playbooks/roles/ai_multifs_run/tasks/main.yml index 38dbba12..d50cec18 100644 --- a/playbooks/roles/ai_multifs_run/tasks/main.yml +++ b/playbooks/roles/ai_multifs_run/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars diff --git a/playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml b/playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml index fd194550..173ac18c 100644 --- a/playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml +++ b/playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml @@ -7,7 +7,7 @@ mount: path: "{{ ai_multifs_mount_point }}" state: unmounted - ignore_errors: yes + ignore_errors: true - name: Create filesystem with specific configuration shell: "{{ fs_config.mkfs_cmd }} {{ ai_multifs_device }}" @@ -30,7 +30,7 @@ file: path: "{{ ai_multifs_results_dir }}/{{ fs_config.name }}" state: directory - mode: '0755' + mode: "0755" - name: Update AI benchmark configuration for current filesystem set_fact: @@ -41,13 +41,13 @@ file: path: "{{ current_fs_benchmark_dir }}" state: directory - mode: '0755' + mode: "0755" - name: Generate AI benchmark configuration for current filesystem template: src: milvus_config.json.j2 dest: "{{ current_fs_results_dir }}/milvus_config.json" - mode: '0644' + mode: "0644" - name: Run AI benchmark on current filesystem shell: | @@ -56,7 +56,7 @@ --config {{ current_fs_results_dir }}/milvus_config.json \ --output {{ current_fs_results_dir }}/results_{{ fs_config.name }}_$(date +%Y%m%d_%H%M%S).json register: benchmark_result - async: 7200 # 2 hour timeout + async: 7200 # 2 hour timeout poll: 30 - name: Display benchmark completion @@ -80,7 +80,7 @@ {{ mkfs_result.stdout }} {{ mkfs_result.stderr }} dest: "{{ current_fs_results_dir }}/filesystem_config.txt" - mode: '0644' + mode: "0644" - name: Capture filesystem statistics after benchmark shell: | @@ -96,7 +96,7 @@ btrfs filesystem show {{ ai_multifs_mount_point }} >> {{ current_fs_results_dir }}/filesystem_stats.txt 2>&1 || true btrfs filesystem usage {{ ai_multifs_mount_point }} >> {{ current_fs_results_dir }}/filesystem_stats.txt 2>&1 || true {% endif %} - ignore_errors: yes + ignore_errors: true - name: Unmount filesystem after benchmark mount: diff --git a/playbooks/roles/ai_multifs_setup/tasks/main.yml b/playbooks/roles/ai_multifs_setup/tasks/main.yml index 28f3ec40..c999133f 100644 --- a/playbooks/roles/ai_multifs_setup/tasks/main.yml +++ b/playbooks/roles/ai_multifs_setup/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -10,19 +10,19 @@ file: path: "{{ ai_multifs_results_dir }}" state: directory - mode: '0755' + mode: "0755" - name: Create mount point directory file: path: "{{ ai_multifs_mount_point }}" state: directory - mode: '0755' + mode: "0755" - name: Unmount any existing filesystem on mount point mount: path: "{{ ai_multifs_mount_point }}" state: unmounted - ignore_errors: yes + ignore_errors: true - name: Install required filesystem utilities package: @@ -67,4 +67,4 @@ Mount options: {{ config.mount_opts }} {% endfor %} dest: "{{ ai_multifs_results_dir }}/test_configuration.txt" - mode: '0644' + mode: "0644" diff --git a/playbooks/roles/ai_results/tasks/main.yml b/playbooks/roles/ai_results/tasks/main.yml index 094a9025..9c56fa2a 100644 --- a/playbooks/roles/ai_results/tasks/main.yml +++ b/playbooks/roles/ai_results/tasks/main.yml @@ -6,7 +6,7 @@ ansible.builtin.file: path: "{{ ai_benchmark_results_dir }}" state: directory - mode: '0755' + mode: "0755" - name: Find all benchmark result files ansible.builtin.find: diff --git a/playbooks/roles/ai_run_benchmarks/tasks/main.yml b/playbooks/roles/ai_run_benchmarks/tasks/main.yml index 72d1a240..62f98fe0 100644 --- a/playbooks/roles/ai_run_benchmarks/tasks/main.yml +++ b/playbooks/roles/ai_run_benchmarks/tasks/main.yml @@ -2,7 +2,7 @@ - name: Import optional extra_args file ansible.builtin.include_vars: "{{ item }}" # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition with_items: - "../extra_vars.yaml" tags: vars @@ -34,7 +34,7 @@ ansible.builtin.file: path: "{{ ai_benchmark_results_dir }}" state: directory - mode: '0755' + mode: "0755" - name: Check for benchmark lock file ansible.builtin.stat: @@ -71,20 +71,20 @@ ansible.builtin.file: path: "{{ ai_benchmark_results_dir }}/.benchmark.lock" state: touch - mode: '0644' + mode: "0644" register: lock_created - name: Create benchmark working directory ansible.builtin.file: path: "{{ ai_benchmark_results_dir }}/workdir" state: directory - mode: '0755' + mode: "0755" - name: Copy benchmark script ansible.builtin.copy: src: milvus_benchmark.py dest: "{{ ai_benchmark_results_dir }}/workdir/milvus_benchmark.py" - mode: '0755' + mode: "0755" - name: Ensure Python venv package is installed ansible.builtin.package: @@ -143,7 +143,7 @@ ansible.builtin.template: src: benchmark_config.json.j2 dest: "{{ ai_benchmark_results_dir }}/workdir/benchmark_config.json" - mode: '0644' + mode: "0644" - name: Wait for Milvus to be ready ansible.builtin.wait_for: diff --git a/playbooks/roles/ai_setup/tasks/main.yml b/playbooks/roles/ai_setup/tasks/main.yml index 899fcee1..e1fd7742 100644 --- a/playbooks/roles/ai_setup/tasks/main.yml +++ b/playbooks/roles/ai_setup/tasks/main.yml @@ -2,7 +2,7 @@ - name: Import optional extra_args file ansible.builtin.include_vars: "{{ item }}" # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition with_items: - "../extra_vars.yaml" tags: vars @@ -11,7 +11,7 @@ ansible.builtin.file: path: "{{ item }}" state: directory - mode: '0755' + mode: "0755" loop: - "{{ ai_docker_data_path }}" - "{{ ai_docker_etcd_data_path }}" @@ -62,7 +62,7 @@ minio_data_path: "{{ ai_docker_minio_data_path }}" minio_memory_limit: "{{ ai_minio_memory_limit }}" minio_docker_network: "{{ ai_docker_network_name }}" - minio_create_network: false # Network already created above + minio_create_network: false # Network already created above when: ai_milvus_docker | bool - name: Wait for etcd to be ready diff --git a/playbooks/roles/ai_uninstall/tasks/main.yml b/playbooks/roles/ai_uninstall/tasks/main.yml index 4d35465b..e8257516 100644 --- a/playbooks/roles/ai_uninstall/tasks/main.yml +++ b/playbooks/roles/ai_uninstall/tasks/main.yml @@ -2,7 +2,7 @@ - name: Import optional extra_args file ansible.builtin.include_vars: "{{ item }}" # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition with_items: - "../extra_vars.yaml" tags: vars @@ -13,7 +13,7 @@ state: absent when: ai_milvus_docker | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Stop and remove MinIO container community.docker.docker_container: @@ -21,7 +21,7 @@ state: absent when: ai_milvus_docker | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Stop and remove etcd container community.docker.docker_container: @@ -29,7 +29,7 @@ state: absent when: ai_milvus_docker | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Remove Docker network community.docker.docker_network: @@ -37,7 +37,7 @@ state: absent when: ai_milvus_docker | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Clean up Python packages (optional) ansible.builtin.pip: @@ -49,7 +49,7 @@ state: absent when: ai_benchmark_enable_graphing | bool # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Display uninstall completion message ansible.builtin.debug: diff --git a/playbooks/roles/base_image/tasks/custom-image.yml b/playbooks/roles/base_image/tasks/custom-image.yml index b443b455..8491788a 100644 --- a/playbooks/roles/base_image/tasks/custom-image.yml +++ b/playbooks/roles/base_image/tasks/custom-image.yml @@ -133,7 +133,6 @@ when: - not sentinel_stat.stat.exists block: - - name: Get the UID of the kdevops user on the control host ansible.builtin.command: cmd: "id -u kdevops" diff --git a/playbooks/roles/gen_hosts/tasks/main.yml b/playbooks/roles/gen_hosts/tasks/main.yml index 83829bd6..0c18b504 100644 --- a/playbooks/roles/gen_hosts/tasks/main.yml +++ b/playbooks/roles/gen_hosts/tasks/main.yml @@ -222,14 +222,14 @@ mode: "0755" - name: Generate the Ansible hosts file for a dedicated MinIO setup - tags: ['hosts'] + tags: ["hosts"] ansible.builtin.template: src: "{{ kdevops_hosts_template }}" dest: "{{ ansible_cfg_inventory }}" force: true - trim_blocks: True - lstrip_blocks: True - mode: '0644' + trim_blocks: true + lstrip_blocks: true + mode: "0644" when: - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_minio|default(false)|bool diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml index 60e7f694..db89a821 100644 --- a/playbooks/roles/gen_nodes/tasks/main.yml +++ b/playbooks/roles/gen_nodes/tasks/main.yml @@ -158,7 +158,7 @@ - not kdevops_enable_nixos|default(false)|bool - name: Generate the NixOS kdevops nodes file using {{ kdevops_nodes_template }} as jinja2 source template - tags: ['nodes'] + tags: ["nodes"] vars: node_template: "{{ kdevops_nodes_template | basename }}" all_generic_nodes: "{{ generic_nodes }}" @@ -172,7 +172,6 @@ - ansible_nodes_template.stat.exists - kdevops_enable_nixos|default(false)|bool - - name: Generate the builder kdevops nodes file using nodes file using template as jinja2 source template tags: ["nodes"] vars: @@ -187,7 +186,6 @@ - bootlinux_builder - ansible_nodes_template.stat.exists - - name: Generate the pynfs kdevops nodes file using nodes file using template as jinja2 source template tags: ["nodes"] vars: @@ -203,7 +201,6 @@ - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_pynfs - - name: Generate the cxl kdevops nodes file using nodes file using template as jinja2 source template tags: ["nodes"] vars: @@ -219,7 +216,6 @@ - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_cxl - - name: Generate a kdevops nodes file for the gitr workflow tags: hosts ansible.builtin.include_role: @@ -356,7 +352,6 @@ when: - is_fstests|bool - - name: Infer enabled blktests test section types ansible.builtin.set_fact: blktests_enabled_test_types: >- @@ -417,7 +412,6 @@ - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_blktests - - name: Infer enabled selftests test section types ansible.builtin.set_fact: selftests_enabled_test_types: >- @@ -468,7 +462,6 @@ - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_selftests - - name: Collect dynamically supported filesystems vars: supported_filesystems_variables: "{{ hostvars[inventory_hostname] | dict2items | selectattr('key', 'search', '^sysbench_supported_filesystem_') }}" @@ -546,7 +539,6 @@ - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_sysbench - - name: Generate the fio-tests kdevops nodes file using nodes file using template as jinja2 source template tags: ["hosts"] vars: @@ -563,7 +555,6 @@ - kdevops_workflow_enable_fio_tests - ansible_nodes_template.stat.exists - - name: Generate the fio-tests kdevops nodes file with dev hosts using nodes file using template as jinja2 source template tags: ["hosts"] vars: @@ -580,7 +571,6 @@ - kdevops_workflow_enable_fio_tests - ansible_nodes_template.stat.exists - - name: Infer enabled mmtests test section types ansible.builtin.set_fact: mmtests_enabled_test_types: >- @@ -631,7 +621,6 @@ - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_mmtests - - name: Generate the reboot-limit kdevops nodes file using nodes file using template as jinja2 source template tags: ["hosts"] vars: @@ -648,7 +637,6 @@ - workflows_reboot_limit - ansible_nodes_template.stat.exists - - name: Generate the reboot-limit kdevops nodes file with dev hosts using nodes file using template as jinja2 source template tags: ["hosts"] vars: @@ -665,9 +653,8 @@ - workflows_reboot_limit - ansible_nodes_template.stat.exists - - name: Generate the AI kdevops nodes file using {{ kdevops_nodes_template }} as jinja2 source template - tags: ['hosts'] + tags: ["hosts"] vars: node_template: "{{ kdevops_nodes_template | basename }}" nodes: "{{ [kdevops_host_prefix + '-ai'] }}" @@ -676,7 +663,7 @@ src: "{{ node_template }}" dest: "{{ topdir_path }}/{{ kdevops_nodes }}" force: true - mode: '0644' + mode: "0644" when: - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_ai @@ -685,7 +672,7 @@ - not ai_enable_multifs_testing|default(false)|bool - name: Generate the AI kdevops nodes file with dev hosts using {{ kdevops_nodes_template }} as jinja2 source template - tags: ['hosts'] + tags: ["hosts"] vars: node_template: "{{ kdevops_nodes_template | basename }}" nodes: "{{ [kdevops_host_prefix + '-ai', kdevops_host_prefix + '-ai-dev'] }}" @@ -694,7 +681,7 @@ src: "{{ node_template }}" dest: "{{ topdir_path }}/{{ kdevops_nodes }}" force: true - mode: '0644' + mode: "0644" when: - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_ai @@ -773,7 +760,7 @@ - ai_multifs_enabled_configs | length > 0 - name: Generate the AI multi-filesystem kdevops nodes file using {{ kdevops_nodes_template }} as jinja2 source template - tags: [ 'hosts' ] + tags: ["hosts"] vars: node_template: "{{ kdevops_nodes_template | basename }}" nodes: "{{ ai_enabled_section_types | regex_replace('\\[') | regex_replace('\\]') | replace(\"'\", '') | split(', ') }}" @@ -781,7 +768,7 @@ template: src: "{{ node_template }}" dest: "{{ topdir_path }}/{{ kdevops_nodes }}" - force: yes + force: true when: - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_ai @@ -851,7 +838,7 @@ - minio_multifs_enabled_configs | length > 0 - name: Generate the MinIO multi-filesystem kdevops nodes file using {{ kdevops_nodes_template }} as jinja2 source template - tags: [ 'hosts' ] + tags: ["hosts"] vars: node_template: "{{ kdevops_nodes_template | basename }}" nodes: "{{ minio_enabled_section_types }}" @@ -860,7 +847,7 @@ src: "{{ node_template }}" dest: "{{ topdir_path }}/{{ kdevops_nodes }}" force: true - mode: '0644' + mode: "0644" when: - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_minio|default(false)|bool @@ -871,7 +858,7 @@ # Standard MinIO single filesystem nodes - name: Generate the MinIO kdevops nodes file using {{ kdevops_nodes_template }} as jinja2 source template - tags: ['hosts'] + tags: ["hosts"] vars: node_template: "{{ kdevops_nodes_template | basename }}" nodes: "{{ [kdevops_host_prefix + '-minio'] }}" @@ -880,7 +867,7 @@ src: "{{ node_template }}" dest: "{{ topdir_path }}/{{ kdevops_nodes }}" force: true - mode: '0644' + mode: "0644" when: - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_minio|default(false)|bool @@ -889,7 +876,7 @@ - not minio_enable_multifs_testing|default(false)|bool - name: Generate the MinIO kdevops nodes file with dev hosts using {{ kdevops_nodes_template }} as jinja2 source template - tags: ['hosts'] + tags: ["hosts"] vars: node_template: "{{ kdevops_nodes_template | basename }}" nodes: "{{ [kdevops_host_prefix + '-minio', kdevops_host_prefix + '-minio-dev'] }}" @@ -898,7 +885,7 @@ src: "{{ node_template }}" dest: "{{ topdir_path }}/{{ kdevops_nodes }}" force: true - mode: '0644' + mode: "0644" when: - kdevops_workflows_dedicated_workflow - kdevops_workflow_enable_minio|default(false)|bool diff --git a/playbooks/roles/guestfs/tasks/bringup/main.yml b/playbooks/roles/guestfs/tasks/bringup/main.yml index bd9f5260..1f664d22 100644 --- a/playbooks/roles/guestfs/tasks/bringup/main.yml +++ b/playbooks/roles/guestfs/tasks/bringup/main.yml @@ -9,7 +9,8 @@ - name: Debug defined VMs debug: - msg: "Hostname: {{ inventory_hostname }}, Defined VMs: {{ hostvars['localhost']['defined_vms']['list_vms'] | default([]) }}, Check: {{ inventory_hostname not in (hostvars['localhost']['defined_vms']['list_vms'] | default([])) }}" + msg: "Hostname: {{ inventory_hostname }}, Defined VMs: {{ hostvars['localhost']['defined_vms']['list_vms'] | default([]) }}, Check: {{ inventory_hostname not + in (hostvars['localhost']['defined_vms']['list_vms'] | default([])) }}" - name: Provision each target node when: diff --git a/playbooks/roles/milvus/defaults/main.yml b/playbooks/roles/milvus/defaults/main.yml index a002196c..8b90002b 100644 --- a/playbooks/roles/milvus/defaults/main.yml +++ b/playbooks/roles/milvus/defaults/main.yml @@ -23,7 +23,7 @@ ai_vector_db_milvus_memory_limit: "8Gi" ai_vector_db_milvus_cpu_limit: "4" # Storage backend -ai_vector_db_milvus_storage_type: "local" # local, s3, minio +ai_vector_db_milvus_storage_type: "local" # local, s3, minio ai_vector_db_milvus_storage_path: "{{ ai_vector_db_milvus_data_dir }}/storage" # Index configuration diff --git a/playbooks/roles/milvus/tasks/benchmark.yml b/playbooks/roles/milvus/tasks/benchmark.yml index 222a00e9..ce999a8d 100644 --- a/playbooks/roles/milvus/tasks/benchmark.yml +++ b/playbooks/roles/milvus/tasks/benchmark.yml @@ -8,7 +8,7 @@ state: started register: milvus_running # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Set Milvus availability flag ansible.builtin.set_fact: @@ -36,13 +36,13 @@ ansible.builtin.file: path: "{{ ai_benchmark_results_dir }}/milvus" state: directory - mode: '0755' + mode: "0755" - name: Generate benchmark configuration ansible.builtin.template: src: benchmark_config.json.j2 dest: "{{ ai_vector_db_milvus_data_dir }}/scripts/benchmark_config.json" - mode: '0644' + mode: "0644" - name: Run Milvus benchmarks ansible.builtin.command: > diff --git a/playbooks/roles/milvus/tasks/benchmark_setup.yml b/playbooks/roles/milvus/tasks/benchmark_setup.yml index 8eb7ce4c..e192a204 100644 --- a/playbooks/roles/milvus/tasks/benchmark_setup.yml +++ b/playbooks/roles/milvus/tasks/benchmark_setup.yml @@ -31,7 +31,7 @@ ansible.builtin.file: path: "{{ ai_vector_db_milvus_data_dir }}/scripts" state: directory - mode: '0755' + mode: "0755" register: scripts_dir_result - name: Check if benchmark scripts exist @@ -46,7 +46,7 @@ ansible.builtin.copy: src: "{{ item.item }}" dest: "{{ ai_vector_db_milvus_data_dir }}/scripts/" - mode: '0755' + mode: "0755" loop: "{{ benchmark_scripts_check.results }}" when: not item.stat.exists or scripts_dir_result is changed @@ -54,4 +54,4 @@ ansible.builtin.template: src: test_connection.py.j2 dest: "{{ ai_vector_db_milvus_data_dir }}/scripts/test_connection.py" - mode: '0755' + mode: "0755" diff --git a/playbooks/roles/milvus/tasks/install_docker.yml b/playbooks/roles/milvus/tasks/install_docker.yml index e1e1d911..eefe3260 100644 --- a/playbooks/roles/milvus/tasks/install_docker.yml +++ b/playbooks/roles/milvus/tasks/install_docker.yml @@ -66,7 +66,7 @@ ansible.builtin.file: path: "{{ item }}" state: directory - mode: '0755' + mode: "0755" owner: "{{ data_user | default(ansible_user_id) }}" become: true loop: @@ -93,5 +93,5 @@ ansible.builtin.template: src: docker-compose.yml.j2 dest: "{{ ai_vector_db_milvus_config_dir }}/docker-compose.yml" - mode: '0644' + mode: "0644" become: true diff --git a/playbooks/roles/milvus/tasks/main.yml b/playbooks/roles/milvus/tasks/main.yml index 4088cb47..fd71f2ed 100644 --- a/playbooks/roles/milvus/tasks/main.yml +++ b/playbooks/roles/milvus/tasks/main.yml @@ -2,7 +2,7 @@ - name: Include role create_data_partition include_role: name: create_data_partition - tags: ['setup', 'data_partition'] + tags: ["setup", "data_partition"] - name: Include role common include_role: @@ -11,7 +11,7 @@ - infer_uid_and_group|bool - name: Ensure data_dir has correct ownership - tags: ['setup'] + tags: ["setup"] become: true # become_method: sudo # sudo is the default, not needed ansible.builtin.file: @@ -20,10 +20,10 @@ group: "{{ data_group }}" recurse: false state: directory - mode: '0755' + mode: "0755" - name: Ensure Milvus-specific subdirectories have correct ownership - tags: ['setup'] + tags: ["setup"] become: true # become_method: sudo # sudo is the default, not needed ansible.builtin.file: @@ -32,7 +32,7 @@ group: "{{ data_group }}" recurse: true state: directory - mode: '0755' + mode: "0755" loop: - "{{ data_path }}/milvus" - "{{ ai_vector_db_milvus_docker_data_path | default(data_path + '/milvus/data') }}" @@ -40,7 +40,7 @@ - "{{ ai_vector_db_milvus_docker_minio_data_path | default(data_path + '/milvus/minio') }}" - "{{ data_path }}/ai-benchmark" # TODO: Review - was ignore_errors: true - failed_when: false # Always succeed - review this condition + failed_when: false # Always succeed - review this condition - name: Include Docker installation tasks ansible.builtin.include_tasks: install_docker.yml diff --git a/playbooks/roles/milvus/tasks/setup.yml b/playbooks/roles/milvus/tasks/setup.yml index e9b8b6d5..a93679db 100644 --- a/playbooks/roles/milvus/tasks/setup.yml +++ b/playbooks/roles/milvus/tasks/setup.yml @@ -72,7 +72,7 @@ ansible.builtin.file: path: "{{ ai_vector_db_milvus_data_dir }}/scripts" state: directory - mode: '0755' + mode: "0755" register: scripts_dir_result - name: Check if benchmark scripts exist @@ -87,7 +87,7 @@ ansible.builtin.copy: src: "{{ item.item }}" dest: "{{ ai_vector_db_milvus_data_dir }}/scripts/" - mode: '0755' + mode: "0755" loop: "{{ benchmark_scripts_check.results }}" when: not item.stat.exists or scripts_dir_result is changed @@ -95,7 +95,7 @@ ansible.builtin.template: src: test_connection.py.j2 dest: "{{ ai_vector_db_milvus_data_dir }}/scripts/test_connection.py" - mode: '0755' + mode: "0755" - name: Test Milvus connection ansible.builtin.command: "{{ data_path }}/ai-benchmark/venv/bin/python {{ ai_vector_db_milvus_data_dir }}/scripts/test_connection.py" diff --git a/playbooks/roles/minio_destroy/tasks/main.yml b/playbooks/roles/minio_destroy/tasks/main.yml index 078cb13f..59f6f11a 100644 --- a/playbooks/roles/minio_destroy/tasks/main.yml +++ b/playbooks/roles/minio_destroy/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -10,13 +10,13 @@ community.docker.docker_container: name: "{{ minio_container_name }}" state: absent - ignore_errors: yes + ignore_errors: true - name: Remove Docker network community.docker.docker_network: name: "{{ minio_docker_network_name }}" state: absent - ignore_errors: yes + ignore_errors: true - name: Clean up MinIO data directory file: diff --git a/playbooks/roles/minio_install/tasks/main.yml b/playbooks/roles/minio_install/tasks/main.yml index 9ea3d758..0215c55e 100644 --- a/playbooks/roles/minio_install/tasks/main.yml +++ b/playbooks/roles/minio_install/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -12,21 +12,21 @@ - docker.io - python3-docker state: present - become: yes + become: true - name: Ensure Docker service is running systemd: name: docker state: started - enabled: yes - become: yes + enabled: true + become: true - name: Add current user to docker group user: name: "{{ ansible_user | default('kdevops') }}" groups: docker - append: yes - become: yes + append: true + become: true - name: Install MinIO Warp block: @@ -34,23 +34,23 @@ get_url: url: "https://github.com/minio/warp/releases/latest/download/warp_Linux_x86_64.tar.gz" dest: "/tmp/warp_Linux_x86_64.tar.gz" - mode: '0644' + mode: "0644" - name: Extract MinIO Warp unarchive: src: "/tmp/warp_Linux_x86_64.tar.gz" dest: "/tmp" - remote_src: yes + remote_src: true - name: Install Warp binary copy: src: "/tmp/warp" dest: "/usr/local/bin/warp" - mode: '0755' + mode: "0755" owner: root group: root - remote_src: yes - become: yes + remote_src: true + become: true - name: Clean up downloaded files file: diff --git a/playbooks/roles/minio_results/tasks/main.yml b/playbooks/roles/minio_results/tasks/main.yml index 74038552..31c0d8df 100644 --- a/playbooks/roles/minio_results/tasks/main.yml +++ b/playbooks/roles/minio_results/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -64,7 +64,7 @@ if __name__ == "__main__": analyze_warp_results() dest: "/tmp/analyze_minio_results.py" - mode: '0755' + mode: "0755" delegate_to: localhost run_once: true diff --git a/playbooks/roles/minio_setup/tasks/main.yml b/playbooks/roles/minio_setup/tasks/main.yml index db7e3d6d..d3385d8c 100644 --- a/playbooks/roles/minio_setup/tasks/main.yml +++ b/playbooks/roles/minio_setup/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -15,7 +15,8 @@ set_fact: minio_mkfs_opts: >- {%- if minio_fstype == "xfs" -%} - -L miniostorage -f -b size={{ minio_xfs_blocksize | default(4096) }} -s size={{ minio_xfs_sectorsize | default(4096) }} {{ minio_xfs_mkfs_opts | default('') }} + -L miniostorage -f -b size={{ minio_xfs_blocksize | default(4096) }} -s size={{ minio_xfs_sectorsize | default(4096) }} {{ minio_xfs_mkfs_opts | default('') + }} {%- elif minio_fstype == "btrfs" -%} -L miniostorage {{ minio_btrfs_mkfs_opts | default('-f') }} {%- elif minio_fstype == "ext4" -%} @@ -42,7 +43,7 @@ file: path: "{{ minio_data_path | default('/data/minio') }}" state: directory - mode: '0755' + mode: "0755" when: - not (minio_storage_enable | default(false) | bool) become: true diff --git a/playbooks/roles/minio_uninstall/tasks/main.yml b/playbooks/roles/minio_uninstall/tasks/main.yml index bea15439..a1521ead 100644 --- a/playbooks/roles/minio_uninstall/tasks/main.yml +++ b/playbooks/roles/minio_uninstall/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -10,7 +10,7 @@ community.docker.docker_container: name: "{{ minio_container_name }}" state: stopped - ignore_errors: yes + ignore_errors: true - name: Display MinIO uninstallation complete debug: diff --git a/playbooks/roles/minio_warp_run/tasks/main.yml b/playbooks/roles/minio_warp_run/tasks/main.yml index 2c073024..c6307619 100644 --- a/playbooks/roles/minio_warp_run/tasks/main.yml +++ b/playbooks/roles/minio_warp_run/tasks/main.yml @@ -1,7 +1,7 @@ --- - name: Import optional extra_args file include_vars: "{{ item }}" - ignore_errors: yes + ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars @@ -10,7 +10,7 @@ file: path: "/tmp/warp-results" state: directory - mode: '0755' + mode: "0755" - name: Ensure local results directory exists with proper permissions block: @@ -18,22 +18,21 @@ file: path: "{{ playbook_dir }}/../workflows/minio/results" state: directory - mode: '0755' + mode: "0755" delegate_to: localhost run_once: true - become: no + become: false rescue: - name: Fix results directory permissions if needed file: path: "{{ playbook_dir }}/../workflows/minio/results" state: directory - mode: '0755' + mode: "0755" owner: "{{ lookup('env', 'USER') }}" group: "{{ lookup('env', 'USER') }}" delegate_to: localhost run_once: true - become: yes - + become: true - name: Wait for MinIO to be fully ready wait_for: @@ -58,7 +57,7 @@ template: src: warp_config.json.j2 dest: "/tmp/warp_config.json" - mode: '0644' + mode: "0644" - name: Set MinIO endpoint URL set_fact: @@ -92,7 +91,7 @@ copy: src: "{{ playbook_dir }}/../workflows/minio/scripts/run_benchmark_suite.sh" dest: "/tmp/run_benchmark_suite.sh" - mode: '0755' + mode: "0755" when: minio_warp_run_comprehensive_suite | default(false) - name: Display benchmark configuration @@ -120,7 +119,7 @@ executable: /bin/bash register: suite_output when: minio_warp_run_comprehensive_suite | default(false) - async: "{{ benchmark_timeout | default(3600) | int }}" # Use calculated timeout or 1 hour default + async: "{{ benchmark_timeout | default(3600) | int }}" # Use calculated timeout or 1 hour default poll: 30 - name: Display comprehensive suite output @@ -209,17 +208,17 @@ fetch: src: "/tmp/warp-results/warp_benchmark_{{ ansible_hostname }}_{{ warp_timestamp }}.json" dest: "{{ playbook_dir }}/../workflows/minio/results/" - flat: yes - become: no + flat: true + become: false when: results_file is defined and not results_file.skipped | default(false) and results_file.stat.exists | default(false) - name: Generate graphs and HTML report command: "python3 {{ playbook_dir }}/../workflows/minio/scripts/generate_warp_report.py {{ playbook_dir }}/../workflows/minio/results/" delegate_to: localhost run_once: true - become: no + become: false when: results_file is defined and not results_file.skipped | default(false) and results_file.stat.exists | default(false) - ignore_errors: yes + ignore_errors: true - name: Save benchmark output as fallback copy: @@ -245,5 +244,5 @@ fetch: src: "/tmp/warp-results/warp_fallback_{{ ansible_hostname }}_{{ warp_timestamp | default(ansible_date_time.epoch) }}.txt" dest: "{{ playbook_dir }}/../workflows/minio/results/" - flat: yes + flat: true when: warp_debug is defined and not (results_file is defined and not results_file.skipped | default(false) and results_file.stat.exists | default(false)) -- 2.50.1