[PATCH 05/10] playbooks: ansible-lint fix fqcn
Daniel Gomez <[email protected]>
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
From: Daniel Gomez <[email protected]> Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]> --- playbooks/ai_multifs.yml | 2 +- playbooks/nixos.yml | 2 +- playbooks/roles/ai_docker_storage/tasks/main.yml | 28 ++++++------ playbooks/roles/ai_install/tasks/main.yml | 4 +- playbooks/roles/ai_milvus_storage/tasks/main.yml | 32 ++++++------- .../ai_multifs_run/tasks/generate_comparison.yml | 6 +-- playbooks/roles/ai_multifs_run/tasks/main.yml | 8 ++-- .../ai_multifs_run/tasks/run_single_filesystem.yml | 26 +++++------ playbooks/roles/ai_multifs_setup/tasks/main.yml | 20 ++++----- playbooks/roles/ai_setup/tasks/main.yml | 2 +- playbooks/roles/common/tasks/main.yml | 8 ++-- playbooks/roles/devconfig/tasks/main.yml | 2 +- playbooks/roles/gen_hosts/tasks/main.yml | 6 +-- playbooks/roles/gen_nodes/tasks/main.yml | 14 +++--- playbooks/roles/guestfs/tasks/bringup/main.yml | 2 +- playbooks/roles/milvus/tasks/main.yml | 4 +- playbooks/roles/minio_destroy/tasks/main.yml | 8 ++-- playbooks/roles/minio_install/tasks/main.yml | 16 +++---- playbooks/roles/minio_results/tasks/main.yml | 10 ++--- playbooks/roles/minio_setup/tasks/main.yml | 16 +++---- playbooks/roles/minio_uninstall/tasks/main.yml | 4 +- playbooks/roles/minio_warp_run/tasks/main.yml | 52 +++++++++++----------- 22 files changed, 136 insertions(+), 136 deletions(-) diff --git a/playbooks/ai_multifs.yml b/playbooks/ai_multifs.yml index f1bedc1f..15f597ec 100644 --- a/playbooks/ai_multifs.yml +++ b/playbooks/ai_multifs.yml @@ -9,7 +9,7 @@ - role: ai_multifs_run tasks: - name: Final multi-filesystem testing summary - debug: + ansible.builtin.debug: msg: | Multi-filesystem AI benchmark testing completed! diff --git a/playbooks/nixos.yml b/playbooks/nixos.yml index 2c959a3a..5cf46289 100644 --- a/playbooks/nixos.yml +++ b/playbooks/nixos.yml @@ -79,7 +79,7 @@ nixos_ssh_key_path: "{{ ssh_key_path_result.stdout | trim }}" - name: Generate SSH key for NixOS VMs if not exists - openssh_keypair: + community.crypto.openssh_keypair: path: "{{ nixos_ssh_key_path }}" type: rsa size: 2048 diff --git a/playbooks/roles/ai_docker_storage/tasks/main.yml b/playbooks/roles/ai_docker_storage/tasks/main.yml index e96b8a2f..c97775e1 100644 --- a/playbooks/roles/ai_docker_storage/tasks/main.yml +++ b/playbooks/roles/ai_docker_storage/tasks/main.yml @@ -1,6 +1,6 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" @@ -10,7 +10,7 @@ when: ai_docker_storage_enable|bool block: - name: Install filesystem utilities - package: + ansible.builtin.package: name: - xfsprogs - e2fsprogs @@ -21,13 +21,13 @@ become_method: sudo - name: Check if device exists - stat: + ansible.builtin.stat: path: "{{ ai_docker_device }}" register: docker_device_stat failed_when: not docker_device_stat.stat.exists - name: Check if Docker storage is already mounted - command: mountpoint -q {{ ai_docker_mount_point }} + ansible.builtin.command: mountpoint -q {{ ai_docker_mount_point }} register: docker_mount_check changed_when: false failed_when: false @@ -36,7 +36,7 @@ when: docker_mount_check.rc != 0 block: - name: Create Docker mount point directory - file: + ansible.builtin.file: path: "{{ ai_docker_mount_point }}" state: directory mode: "0755" @@ -44,7 +44,7 @@ become_method: sudo - name: Format device with XFS - command: > + ansible.builtin.command: > mkfs.xfs -f -b size={{ ai_docker_xfs_blocksize | default(4096) }} -s size={{ ai_docker_xfs_sectorsize | default(4096) }} @@ -55,19 +55,19 @@ become_method: sudo - name: Format device with Btrfs - command: mkfs.btrfs {{ ai_docker_btrfs_mkfs_opts }} {{ ai_docker_device }} + ansible.builtin.command: mkfs.btrfs {{ ai_docker_btrfs_mkfs_opts }} {{ ai_docker_device }} when: ai_docker_fstype == "btrfs" become: true become_method: sudo - name: Format device with ext4 - command: mkfs.ext4 {{ ai_docker_ext4_mkfs_opts }} {{ ai_docker_device }} + ansible.builtin.command: mkfs.ext4 {{ ai_docker_ext4_mkfs_opts }} {{ ai_docker_device }} when: ai_docker_fstype == "ext4" become: true become_method: sudo - name: Mount Docker storage filesystem - mount: + ansible.posix.mount: path: "{{ ai_docker_mount_point }}" src: "{{ ai_docker_device }}" fstype: "{{ ai_docker_fstype }}" @@ -77,7 +77,7 @@ become_method: sudo - name: Add Docker storage mount to fstab - mount: + ansible.posix.mount: path: "{{ ai_docker_mount_point }}" src: "{{ ai_docker_device }}" fstype: "{{ ai_docker_fstype }}" @@ -87,14 +87,14 @@ become_method: sudo - name: Check if Docker service exists - systemd: + ansible.builtin.systemd: name: docker register: docker_service_status failed_when: false changed_when: false - name: Stop Docker service if running - systemd: + ansible.builtin.systemd: name: docker state: stopped become: true @@ -106,7 +106,7 @@ # No need to move data or create symlinks as the storage is already in the right place - name: Ensure Docker directory has proper permissions - file: + ansible.builtin.file: path: "{{ ai_docker_mount_point }}" state: directory mode: "0711" @@ -119,5 +119,5 @@ # Docker will be installed and started later by the ai role # We only prepare the storage here - name: Display Docker storage setup complete - debug: + ansible.builtin.debug: msg: "Docker storage has been prepared at: {{ ai_docker_mount_point }}" diff --git a/playbooks/roles/ai_install/tasks/main.yml b/playbooks/roles/ai_install/tasks/main.yml index 96cc17b4..8e11050b 100644 --- a/playbooks/roles/ai_install/tasks/main.yml +++ b/playbooks/roles/ai_install/tasks/main.yml @@ -1,11 +1,11 @@ --- - name: Include role create_data_partition - include_role: + ansible.builtin.include_role: name: create_data_partition tags: ["setup", "data_partition"] - name: Include role common - include_role: + ansible.builtin.include_role: name: common when: - infer_uid_and_group|bool diff --git a/playbooks/roles/ai_milvus_storage/tasks/main.yml b/playbooks/roles/ai_milvus_storage/tasks/main.yml index 7fb85393..d2b21906 100644 --- a/playbooks/roles/ai_milvus_storage/tasks/main.yml +++ b/playbooks/roles/ai_milvus_storage/tasks/main.yml @@ -1,6 +1,6 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" @@ -10,7 +10,7 @@ when: ai_milvus_storage_enable|bool block: - name: Install filesystem utilities - package: + ansible.builtin.package: name: - xfsprogs - e2fsprogs @@ -20,13 +20,13 @@ become_method: sudo - name: Check if device exists - stat: + ansible.builtin.stat: path: "{{ ai_milvus_device }}" register: milvus_device_stat failed_when: not milvus_device_stat.stat.exists - name: Check if Milvus storage is already mounted - command: mountpoint -q {{ ai_milvus_mount_point }} + ansible.builtin.command: mountpoint -q {{ ai_milvus_mount_point }} register: milvus_mount_check changed_when: false failed_when: false @@ -35,7 +35,7 @@ when: milvus_mount_check.rc != 0 block: - name: Create Milvus mount point directory - file: + ansible.builtin.file: path: "{{ ai_milvus_mount_point }}" state: directory mode: "0755" @@ -43,7 +43,7 @@ become_method: sudo - name: Detect filesystem type from node name - set_fact: + ansible.builtin.set_fact: detected_fstype: >- {%- if 'xfs' in inventory_hostname -%} xfs @@ -57,7 +57,7 @@ when: ai_milvus_use_node_fs | default(false) | bool - name: Detect XFS parameters from node name - set_fact: + ansible.builtin.set_fact: milvus_xfs_blocksize: >- {%- if '64k' in inventory_hostname -%} 65536 @@ -81,7 +81,7 @@ - detected_fstype | default(ai_milvus_fstype) == 'xfs' - name: Detect ext4 parameters from node name - set_fact: + ansible.builtin.set_fact: milvus_ext4_opts: >- {%- if '16k' in inventory_hostname and 'bigalloc' in inventory_hostname -%} -F -b 4096 -C 16384 -O bigalloc @@ -95,11 +95,11 @@ - detected_fstype | default(ai_milvus_fstype) == 'ext4' - name: Set final filesystem type - set_fact: + ansible.builtin.set_fact: milvus_fstype: "{{ detected_fstype | default(ai_milvus_fstype | default('xfs')) }}" - name: Format device with XFS - command: > + ansible.builtin.command: > mkfs.xfs -f -b size={{ milvus_xfs_blocksize | default(ai_milvus_xfs_blocksize | default(4096)) }} -s size={{ milvus_xfs_sectorsize | default(ai_milvus_xfs_sectorsize | default(4096)) }} @@ -110,19 +110,19 @@ become_method: sudo - name: Format device with Btrfs - command: mkfs.btrfs {{ ai_milvus_btrfs_mkfs_opts | default('-f') }} {{ ai_milvus_device }} + ansible.builtin.command: mkfs.btrfs {{ ai_milvus_btrfs_mkfs_opts | default('-f') }} {{ ai_milvus_device }} when: milvus_fstype == "btrfs" become: true become_method: sudo - name: Format device with ext4 - command: mkfs.ext4 {{ milvus_ext4_opts | default(ai_milvus_ext4_mkfs_opts | default('-F')) }} {{ ai_milvus_device }} + ansible.builtin.command: mkfs.ext4 {{ milvus_ext4_opts | default(ai_milvus_ext4_mkfs_opts | default('-F')) }} {{ ai_milvus_device }} when: milvus_fstype == "ext4" become: true become_method: sudo - name: Mount Milvus storage filesystem - mount: + ansible.posix.mount: path: "{{ ai_milvus_mount_point }}" src: "{{ ai_milvus_device }}" fstype: "{{ milvus_fstype }}" @@ -132,7 +132,7 @@ become_method: sudo - name: Add Milvus storage mount to fstab - mount: + ansible.posix.mount: path: "{{ ai_milvus_mount_point }}" src: "{{ ai_milvus_device }}" fstype: "{{ milvus_fstype }}" @@ -142,7 +142,7 @@ become_method: sudo - name: Ensure Milvus directories exist with proper permissions - file: + ansible.builtin.file: path: "{{ item }}" state: directory mode: "0755" @@ -157,5 +157,5 @@ - "{{ ai_milvus_mount_point }}/minio" - name: Display Milvus storage setup complete - debug: + ansible.builtin.debug: msg: "Milvus storage has been prepared at: {{ ai_milvus_mount_point }} with filesystem: {{ milvus_fstype | default(ai_milvus_fstype | default('xfs')) }}" diff --git a/playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml b/playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml index 2416f393..e4a0c0a9 100644 --- a/playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml +++ b/playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml @@ -1,6 +1,6 @@ --- - name: Create multi-filesystem comparison script - copy: + ansible.builtin.copy: content: | #!/usr/bin/env python3 """ @@ -268,11 +268,11 @@ mode: "0755" - name: Run multi-filesystem comparison analysis - command: python3 {{ ai_multifs_results_dir }}/generate_comparison.py + ansible.builtin.command: python3 {{ ai_multifs_results_dir }}/generate_comparison.py register: comparison_result - name: Display comparison completion message - debug: + ansible.builtin.debug: msg: | Multi-filesystem comparison completed! Comparison report: {{ ai_multifs_results_dir }}/comparison/multi_filesystem_comparison.html diff --git a/playbooks/roles/ai_multifs_run/tasks/main.yml b/playbooks/roles/ai_multifs_run/tasks/main.yml index d50cec18..382332c9 100644 --- a/playbooks/roles/ai_multifs_run/tasks/main.yml +++ b/playbooks/roles/ai_multifs_run/tasks/main.yml @@ -1,17 +1,17 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars - name: Filter enabled filesystem configurations - set_fact: + ansible.builtin.set_fact: enabled_fs_configs: "{{ ai_multifs_configurations | selectattr('enabled', 'equalto', true) | list }}" - name: Run AI benchmarks on each filesystem configuration - include_tasks: run_single_filesystem.yml + ansible.builtin.include_tasks: run_single_filesystem.yml loop: "{{ enabled_fs_configs }}" loop_control: loop_var: fs_config @@ -19,5 +19,5 @@ when: enabled_fs_configs | length > 0 - name: Generate multi-filesystem comparison report - include_tasks: generate_comparison.yml + ansible.builtin.include_tasks: generate_comparison.yml when: enabled_fs_configs | length > 1 diff --git a/playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml b/playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml index a4ed4cdd..7a282629 100644 --- a/playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml +++ b/playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml @@ -1,10 +1,10 @@ --- - name: Display current filesystem configuration - debug: + ansible.builtin.debug: msg: "Testing filesystem configuration {{ fs_index + 1 }}/{{ enabled_fs_configs | length }}: {{ fs_config.name }}" - name: Unmount filesystem if mounted - mount: + ansible.posix.mount: path: "{{ ai_multifs_mount_point }}" state: unmounted ignore_errors: true @@ -14,12 +14,12 @@ register: mkfs_result - name: Display mkfs output - debug: + ansible.builtin.debug: msg: "mkfs output: {{ mkfs_result.stdout }}" when: mkfs_result.stdout != "" - name: Mount filesystem with specific options - mount: + ansible.posix.mount: path: "{{ ai_multifs_mount_point }}" src: "{{ ai_multifs_device }}" fstype: "{{ fs_config.filesystem }}" @@ -27,30 +27,30 @@ state: mounted - name: Create filesystem-specific results directory - file: + ansible.builtin.file: path: "{{ ai_multifs_results_dir }}/{{ fs_config.name }}" state: directory mode: "0755" - name: Update AI benchmark configuration for current filesystem - set_fact: + ansible.builtin.set_fact: current_fs_benchmark_dir: "{{ ai_multifs_mount_point }}/ai-benchmark-data" current_fs_results_dir: "{{ ai_multifs_results_dir }}/{{ fs_config.name }}" - name: Create AI benchmark data directory on current filesystem - file: + ansible.builtin.file: path: "{{ current_fs_benchmark_dir }}" state: directory mode: "0755" - name: Generate AI benchmark configuration for current filesystem - template: + ansible.builtin.template: src: milvus_config.json.j2 dest: "{{ current_fs_results_dir }}/milvus_config.json" mode: "0644" - name: Run AI benchmark on current filesystem - shell: | + ansible.builtin.shell: | cd {{ current_fs_benchmark_dir }} python3 {{ playbook_dir }}/roles/ai_run_benchmarks/files/milvus_benchmark.py \ --config {{ current_fs_results_dir }}/milvus_config.json \ @@ -60,11 +60,11 @@ poll: 30 - name: Display benchmark completion - debug: + ansible.builtin.debug: msg: "Benchmark completed for {{ fs_config.name }}: {{ benchmark_result.stdout_lines[-5:] | default(['No output']) }}" - name: Record filesystem configuration metadata - copy: + ansible.builtin.copy: content: | # Filesystem Configuration: {{ fs_config.name }} Filesystem Type: {{ fs_config.filesystem }} @@ -83,7 +83,7 @@ mode: "0644" - name: Capture filesystem statistics after benchmark - shell: | + ansible.builtin.shell: | echo "=== Filesystem Usage ===" > {{ current_fs_results_dir }}/filesystem_stats.txt df -h {{ ai_multifs_mount_point }} >> {{ current_fs_results_dir }}/filesystem_stats.txt echo "" >> {{ current_fs_results_dir }}/filesystem_stats.txt @@ -99,6 +99,6 @@ ignore_errors: true - name: Unmount filesystem after benchmark - mount: + ansible.posix.mount: path: "{{ ai_multifs_mount_point }}" state: unmounted diff --git a/playbooks/roles/ai_multifs_setup/tasks/main.yml b/playbooks/roles/ai_multifs_setup/tasks/main.yml index c999133f..10ab8111 100644 --- a/playbooks/roles/ai_multifs_setup/tasks/main.yml +++ b/playbooks/roles/ai_multifs_setup/tasks/main.yml @@ -1,31 +1,31 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars - name: Create multi-filesystem results directory - file: + ansible.builtin.file: path: "{{ ai_multifs_results_dir }}" state: directory mode: "0755" - name: Create mount point directory - file: + ansible.builtin.file: path: "{{ ai_multifs_mount_point }}" state: directory mode: "0755" - name: Unmount any existing filesystem on mount point - mount: + ansible.posix.mount: path: "{{ ai_multifs_mount_point }}" state: unmounted ignore_errors: true - name: Install required filesystem utilities - package: + ansible.builtin.package: name: - xfsprogs - e2fsprogs @@ -33,25 +33,25 @@ state: present - name: Filter enabled filesystem configurations - set_fact: + ansible.builtin.set_fact: enabled_fs_configs: "{{ ai_multifs_configurations | selectattr('enabled', 'equalto', true) | list }}" - name: Display enabled filesystem configurations - debug: + ansible.builtin.debug: msg: "Will test {{ enabled_fs_configs | length }} filesystem configurations: {{ enabled_fs_configs | map(attribute='name') | list }}" - name: Validate that device exists - stat: + ansible.builtin.stat: path: "{{ ai_multifs_device }}" register: device_stat failed_when: not device_stat.stat.exists - name: Display device information - debug: + ansible.builtin.debug: msg: "Using device {{ ai_multifs_device }} for multi-filesystem testing" - name: Create filesystem configuration summary - copy: + ansible.builtin.copy: content: | # AI Multi-Filesystem Testing Configuration Generated: {{ ansible_date_time.iso8601 }} diff --git a/playbooks/roles/ai_setup/tasks/main.yml b/playbooks/roles/ai_setup/tasks/main.yml index e1fd7742..33536ddd 100644 --- a/playbooks/roles/ai_setup/tasks/main.yml +++ b/playbooks/roles/ai_setup/tasks/main.yml @@ -50,7 +50,7 @@ when: ai_milvus_docker | bool - name: Setup MinIO using shared role - include_role: + ansible.builtin.include_role: name: minio_setup vars: minio_container_image: "{{ ai_minio_container_image_string }}" diff --git a/playbooks/roles/common/tasks/main.yml b/playbooks/roles/common/tasks/main.yml index bb92fea8..f0aa645f 100644 --- a/playbooks/roles/common/tasks/main.yml +++ b/playbooks/roles/common/tasks/main.yml @@ -56,14 +56,14 @@ - infer_uid_and_group|bool - name: Get primary group ID from user entry - set_fact: + ansible.builtin.set_fact: user_primary_gid: "{{ getent_running_user.ansible_facts.getent_passwd[target_user][2] }}" when: - infer_uid_and_group|bool - getent_on_group.rc | default(1) != 0 - name: Run getent against the primary group ID - getent: + ansible.builtin.getent: database: group key: "{{ user_primary_gid }}" register: getent_primary_group @@ -72,7 +72,7 @@ - getent_on_group.rc | default(1) != 0 - name: Override user and group with inferred settings if feature is enabled (group found by name) - set_fact: + ansible.builtin.set_fact: data_user: "{{ target_user }}" data_group: "{{ ((getent_on_group.values() | first).values() | first).keys() | first }}" when: @@ -80,7 +80,7 @@ - getent_on_group.rc | default(1) == 0 - name: Override user and group with inferred settings if feature is enabled (group found by GID) - set_fact: + ansible.builtin.set_fact: data_user: "{{ target_user }}" data_group: "{{ getent_primary_group.ansible_facts.getent_group.keys() | first }}" when: diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml index 6bd0c1f6..fbe9165e 100644 --- a/playbooks/roles/devconfig/tasks/main.yml +++ b/playbooks/roles/devconfig/tasks/main.yml @@ -35,7 +35,7 @@ changed_when: false - name: Set inferred user and group for declared hosts - set_fact: + ansible.builtin.set_fact: data_user: "{{ declared_host_user.stdout | default(data_user) }}" data_group: "{{ declared_host_group.stdout | default(data_group) }}" when: diff --git a/playbooks/roles/gen_hosts/tasks/main.yml b/playbooks/roles/gen_hosts/tasks/main.yml index 0c18b504..96632184 100644 --- a/playbooks/roles/gen_hosts/tasks/main.yml +++ b/playbooks/roles/gen_hosts/tasks/main.yml @@ -11,7 +11,7 @@ tags: vars - name: Parse declared hosts list when using declared hosts - set_fact: + ansible.builtin.set_fact: kdevops_declared_hosts: >- {%- if kdevops_declared_hosts is string -%} {{ (kdevops_declared_hosts | default('')) | regex_replace(',', ' ') | split() }} @@ -174,7 +174,7 @@ - not kdevops_use_declared_hosts - name: Load AI nodes configuration for multi-filesystem setup - include_vars: + ansible.builtin.include_vars: file: "{{ topdir_path }}/{{ kdevops_nodes }}" name: guestfs_nodes when: @@ -184,7 +184,7 @@ - ansible_hosts_template.stat.exists - name: Extract AI node names for multi-filesystem setup - set_fact: + ansible.builtin.set_fact: all_generic_nodes: "{{ guestfs_nodes.guestfs_nodes | map(attribute='name') | list }}" when: - kdevops_workflows_dedicated_workflow diff --git a/playbooks/roles/gen_nodes/tasks/main.yml b/playbooks/roles/gen_nodes/tasks/main.yml index db89a821..44a418b2 100644 --- a/playbooks/roles/gen_nodes/tasks/main.yml +++ b/playbooks/roles/gen_nodes/tasks/main.yml @@ -723,7 +723,7 @@ if kdevops_config_data | regex_search('^CONFIG_AI_MULTIFS_TEST_BTRFS=y$', multiline=True) else [] }} - set_fact: + ansible.builtin.set_fact: ai_multifs_enabled_configs: "{{ (xfs_configs + ext4_configs + btrfs_configs) | unique }}" when: - kdevops_workflows_dedicated_workflow @@ -734,7 +734,7 @@ - name: Create AI nodes for each filesystem configuration (no dev) vars: filesystem_nodes: "{{ [kdevops_host_prefix + '-ai-'] | product(ai_multifs_enabled_configs | default([])) | map('join') | list }}" - set_fact: + ansible.builtin.set_fact: ai_enabled_section_types: "{{ filesystem_nodes }}" when: - kdevops_workflows_dedicated_workflow @@ -748,7 +748,7 @@ - name: Create AI nodes for each filesystem configuration with dev hosts vars: filesystem_nodes: "{{ [kdevops_host_prefix + '-ai-'] | product(ai_multifs_enabled_configs | default([])) | map('join') | list }}" - set_fact: + ansible.builtin.set_fact: ai_enabled_section_types: "{{ filesystem_nodes | product(['', '-dev']) | map('join') | list }}" when: - kdevops_workflows_dedicated_workflow @@ -765,7 +765,7 @@ node_template: "{{ kdevops_nodes_template | basename }}" nodes: "{{ ai_enabled_section_types | regex_replace('\\[') | regex_replace('\\]') | replace(\"'\", '') | split(', ') }}" all_generic_nodes: "{{ ai_enabled_section_types }}" - template: + ansible.builtin.template: src: "{{ node_template }}" dest: "{{ topdir_path }}/{{ kdevops_nodes }}" force: true @@ -801,7 +801,7 @@ [] + (['btrfs'] if minio_multifs_btrfs_default|default(false)|bool else []) }} - set_fact: + ansible.builtin.set_fact: minio_multifs_enabled_configs: "{{ (xfs_configs + ext4_configs + btrfs_configs) | unique }}" when: - kdevops_workflows_dedicated_workflow @@ -812,7 +812,7 @@ - name: Create MinIO nodes for each filesystem configuration (no dev) vars: filesystem_nodes: "{{ [kdevops_host_prefix + '-minio-'] | product(minio_multifs_enabled_configs | default([])) | map('join') | list }}" - set_fact: + ansible.builtin.set_fact: minio_enabled_section_types: "{{ filesystem_nodes }}" when: - kdevops_workflows_dedicated_workflow @@ -826,7 +826,7 @@ - name: Create MinIO nodes for each filesystem configuration with dev hosts vars: filesystem_nodes: "{{ [kdevops_host_prefix + '-minio-'] | product(minio_multifs_enabled_configs | default([])) | map('join') | list }}" - set_fact: + ansible.builtin.set_fact: minio_enabled_section_types: "{{ filesystem_nodes | product(['', '-dev']) | map('join') | list }}" when: - kdevops_workflows_dedicated_workflow diff --git a/playbooks/roles/guestfs/tasks/bringup/main.yml b/playbooks/roles/guestfs/tasks/bringup/main.yml index 1f664d22..4f2a1667 100644 --- a/playbooks/roles/guestfs/tasks/bringup/main.yml +++ b/playbooks/roles/guestfs/tasks/bringup/main.yml @@ -8,7 +8,7 @@ register: defined_vms - name: Debug defined VMs - debug: + ansible.builtin.debug: msg: "Hostname: {{ inventory_hostname }}, Defined VMs: {{ hostvars['localhost']['defined_vms']['list_vms'] | default([]) }}, Check: {{ inventory_hostname not in (hostvars['localhost']['defined_vms']['list_vms'] | default([])) }}" diff --git a/playbooks/roles/milvus/tasks/main.yml b/playbooks/roles/milvus/tasks/main.yml index fd71f2ed..4e45cb3d 100644 --- a/playbooks/roles/milvus/tasks/main.yml +++ b/playbooks/roles/milvus/tasks/main.yml @@ -1,11 +1,11 @@ --- - name: Include role create_data_partition - include_role: + ansible.builtin.include_role: name: create_data_partition tags: ["setup", "data_partition"] - name: Include role common - include_role: + ansible.builtin.include_role: name: common when: - infer_uid_and_group|bool diff --git a/playbooks/roles/minio_destroy/tasks/main.yml b/playbooks/roles/minio_destroy/tasks/main.yml index 59f6f11a..0ea9a5d1 100644 --- a/playbooks/roles/minio_destroy/tasks/main.yml +++ b/playbooks/roles/minio_destroy/tasks/main.yml @@ -1,6 +1,6 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" @@ -19,16 +19,16 @@ ignore_errors: true - name: Clean up MinIO data directory - file: + ansible.builtin.file: path: "{{ minio_data_path }}" state: absent when: minio_warp_enable_cleanup | default(true) | bool - name: Clean up temporary Warp results - file: + ansible.builtin.file: path: "/tmp/warp-results" state: absent - name: Display MinIO destroy complete - debug: + ansible.builtin.debug: msg: "MinIO containers and data have been cleaned up" diff --git a/playbooks/roles/minio_install/tasks/main.yml b/playbooks/roles/minio_install/tasks/main.yml index 0215c55e..ed4badeb 100644 --- a/playbooks/roles/minio_install/tasks/main.yml +++ b/playbooks/roles/minio_install/tasks/main.yml @@ -1,13 +1,13 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars - name: Install Docker - package: + ansible.builtin.package: name: - docker.io - python3-docker @@ -15,14 +15,14 @@ become: true - name: Ensure Docker service is running - systemd: + ansible.builtin.systemd: name: docker state: started enabled: true become: true - name: Add current user to docker group - user: + ansible.builtin.user: name: "{{ ansible_user | default('kdevops') }}" groups: docker append: true @@ -31,19 +31,19 @@ - name: Install MinIO Warp block: - name: Download MinIO Warp binary - get_url: + ansible.builtin.get_url: url: "https://github.com/minio/warp/releases/latest/download/warp_Linux_x86_64.tar.gz" dest: "/tmp/warp_Linux_x86_64.tar.gz" mode: "0644" - name: Extract MinIO Warp - unarchive: + ansible.builtin.unarchive: src: "/tmp/warp_Linux_x86_64.tar.gz" dest: "/tmp" remote_src: true - name: Install Warp binary - copy: + ansible.builtin.copy: src: "/tmp/warp" dest: "/usr/local/bin/warp" mode: "0755" @@ -53,7 +53,7 @@ become: true - name: Clean up downloaded files - file: + ansible.builtin.file: path: "{{ item }}" state: absent loop: diff --git a/playbooks/roles/minio_results/tasks/main.yml b/playbooks/roles/minio_results/tasks/main.yml index 31c0d8df..a2530155 100644 --- a/playbooks/roles/minio_results/tasks/main.yml +++ b/playbooks/roles/minio_results/tasks/main.yml @@ -1,13 +1,13 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars - name: Create results analysis script - copy: + ansible.builtin.copy: content: | #!/usr/bin/env python3 import json @@ -69,17 +69,17 @@ run_once: true - name: Run results analysis - command: python3 /tmp/analyze_minio_results.py + ansible.builtin.command: python3 /tmp/analyze_minio_results.py register: analysis_output delegate_to: localhost run_once: true - name: Display analysis results - debug: + ansible.builtin.debug: var: analysis_output.stdout_lines - name: Create results summary file - copy: + ansible.builtin.copy: content: "{{ analysis_output.stdout }}" dest: "{{ playbook_dir }}/../workflows/minio/results/benchmark_summary.txt" delegate_to: localhost diff --git a/playbooks/roles/minio_setup/tasks/main.yml b/playbooks/roles/minio_setup/tasks/main.yml index d3385d8c..be77b8c0 100644 --- a/playbooks/roles/minio_setup/tasks/main.yml +++ b/playbooks/roles/minio_setup/tasks/main.yml @@ -1,6 +1,6 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" @@ -12,7 +12,7 @@ - minio_device is defined block: - name: Prepare filesystem mkfs options - set_fact: + ansible.builtin.set_fact: minio_mkfs_opts: >- {%- if minio_fstype == "xfs" -%} -L miniostorage -f -b size={{ minio_xfs_blocksize | default(4096) }} -s size={{ minio_xfs_sectorsize | default(4096) }} {{ minio_xfs_mkfs_opts | default('') @@ -28,7 +28,7 @@ {%- endif -%} - name: Create MinIO storage filesystem - include_role: + ansible.builtin.include_role: name: create_partition vars: disk_setup_device: "{{ minio_device }}" @@ -40,7 +40,7 @@ disk_setup_group: "root" - name: Create MinIO data directory - file: + ansible.builtin.file: path: "{{ minio_data_path | default('/data/minio') }}" state: directory mode: "0755" @@ -49,18 +49,18 @@ become: true - name: Check filesystem type for MinIO data path - shell: df -T "{{ minio_data_path }}" | tail -1 | awk '{print $2}' + ansible.builtin.shell: df -T "{{ minio_data_path }}" | tail -1 | awk '{print $2}' register: minio_fs_type changed_when: false - name: Get filesystem details - shell: | + ansible.builtin.shell: | df -h "{{ minio_data_path }}" | tail -1 register: minio_fs_details changed_when: false - name: Display filesystem information - debug: + ansible.builtin.debug: msg: | MinIO Storage Configuration: Data Path: {{ minio_data_path }} @@ -94,7 +94,7 @@ when: minio_enable | bool - name: Wait for MinIO to be ready - wait_for: + ansible.builtin.wait_for: host: localhost port: "{{ minio_api_port }}" timeout: 60 diff --git a/playbooks/roles/minio_uninstall/tasks/main.yml b/playbooks/roles/minio_uninstall/tasks/main.yml index a1521ead..53892d6f 100644 --- a/playbooks/roles/minio_uninstall/tasks/main.yml +++ b/playbooks/roles/minio_uninstall/tasks/main.yml @@ -1,6 +1,6 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" @@ -13,5 +13,5 @@ ignore_errors: true - name: Display MinIO uninstallation complete - debug: + ansible.builtin.debug: msg: "MinIO container stopped" diff --git a/playbooks/roles/minio_warp_run/tasks/main.yml b/playbooks/roles/minio_warp_run/tasks/main.yml index c6307619..e6318fc0 100644 --- a/playbooks/roles/minio_warp_run/tasks/main.yml +++ b/playbooks/roles/minio_warp_run/tasks/main.yml @@ -1,13 +1,13 @@ --- - name: Import optional extra_args file - include_vars: "{{ item }}" + ansible.builtin.include_vars: "{{ item }}" ignore_errors: true with_items: - "../extra_vars.yaml" tags: vars - name: Create Warp results directory on remote host - file: + ansible.builtin.file: path: "/tmp/warp-results" state: directory mode: "0755" @@ -15,7 +15,7 @@ - name: Ensure local results directory exists with proper permissions block: - name: Create local results directory - file: + ansible.builtin.file: path: "{{ playbook_dir }}/../workflows/minio/results" state: directory mode: "0755" @@ -24,7 +24,7 @@ become: false rescue: - name: Fix results directory permissions if needed - file: + ansible.builtin.file: path: "{{ playbook_dir }}/../workflows/minio/results" state: directory mode: "0755" @@ -35,7 +35,7 @@ become: true - name: Wait for MinIO to be fully ready - wait_for: + ansible.builtin.wait_for: host: localhost port: "{{ minio_api_port }}" timeout: 120 @@ -43,37 +43,37 @@ delay: 10 - name: Check if Warp is installed - command: which warp + ansible.builtin.command: which warp register: warp_check failed_when: false changed_when: false - name: Verify Warp installation - fail: + ansible.builtin.fail: msg: "MinIO Warp is not installed. Please run 'make minio-install' first." when: warp_check.rc != 0 - name: Create Warp configuration file - template: + ansible.builtin.template: src: warp_config.json.j2 dest: "/tmp/warp_config.json" mode: "0644" - name: Set MinIO endpoint URL - set_fact: + ansible.builtin.set_fact: minio_endpoint: "localhost:{{ minio_api_port }}" - name: Display Warp version - command: warp --version + ansible.builtin.command: warp --version register: warp_version changed_when: false - name: Show Warp version - debug: + ansible.builtin.debug: msg: "MinIO Warp version: {{ warp_version.stdout }}" - name: Calculate benchmark timeout - set_fact: + ansible.builtin.set_fact: # Parse duration and add 10 minutes buffer benchmark_timeout: >- {%- set duration_str = minio_warp_duration | string -%} @@ -88,14 +88,14 @@ {%- endif -%} - name: Copy comprehensive benchmark script - copy: + ansible.builtin.copy: src: "{{ playbook_dir }}/../workflows/minio/scripts/run_benchmark_suite.sh" dest: "/tmp/run_benchmark_suite.sh" mode: "0755" when: minio_warp_run_comprehensive_suite | default(false) - name: Display benchmark configuration - debug: + ansible.builtin.debug: msg: | Comprehensive suite: {{ minio_warp_run_comprehensive_suite | default(false) }} Duration: {{ minio_warp_duration }} @@ -103,7 +103,7 @@ when: minio_warp_run_comprehensive_suite | default(false) - name: Run comprehensive benchmark suite - shell: | + ansible.builtin.shell: | set -x # Enable debug output echo "Starting comprehensive benchmark suite" echo "Duration parameter: {{ minio_warp_duration }}" @@ -123,7 +123,7 @@ poll: 30 - name: Display comprehensive suite output - debug: + ansible.builtin.debug: msg: | Suite completed: {{ suite_output is defined }} Exit code: {{ suite_output.rc | default('N/A') }} @@ -131,19 +131,19 @@ when: minio_warp_run_comprehensive_suite | default(false) - name: Debug - Show which path we're taking - debug: + ansible.builtin.debug: msg: | Comprehensive suite enabled: {{ minio_warp_run_comprehensive_suite | default(false) }} Duration: {{ minio_warp_duration }} Benchmark timeout: {{ benchmark_timeout }} seconds - name: Set timestamp for consistent filename - set_fact: + ansible.builtin.set_fact: warp_timestamp: "{{ ansible_date_time.epoch }}" when: not (minio_warp_run_comprehensive_suite | default(false)) - name: Run MinIO Warp single benchmark with JSON output - shell: | + ansible.builtin.shell: | echo "=== Starting single benchmark ===" echo "Duration: {{ minio_warp_duration }}" echo "Full command:" @@ -189,23 +189,23 @@ when: not (minio_warp_run_comprehensive_suite | default(false)) - name: Display benchmark completion - debug: + ansible.builtin.debug: msg: "MinIO Warp benchmark completed on {{ ansible_hostname }}" when: (warp_output is defined and warp_output.rc | default(1) == 0) or (suite_output is defined and suite_output.rc | default(1) == 0) - name: Check if results file exists - stat: + ansible.builtin.stat: path: "/tmp/warp-results/warp_benchmark_{{ ansible_hostname }}_{{ warp_timestamp }}.json" register: results_file when: warp_timestamp is defined - name: Display results file status - debug: + ansible.builtin.debug: msg: "Results file exists: {{ results_file.stat.exists }}, Size: {{ results_file.stat.size | default(0) }} bytes" when: results_file is defined and not results_file.skipped | default(false) - name: Copy results to local system - fetch: + ansible.builtin.fetch: src: "/tmp/warp-results/warp_benchmark_{{ ansible_hostname }}_{{ warp_timestamp }}.json" dest: "{{ playbook_dir }}/../workflows/minio/results/" flat: true @@ -213,7 +213,7 @@ when: results_file is defined and not results_file.skipped | default(false) and results_file.stat.exists | default(false) - name: Generate graphs and HTML report - command: "python3 {{ playbook_dir }}/../workflows/minio/scripts/generate_warp_report.py {{ playbook_dir }}/../workflows/minio/results/" + ansible.builtin.command: "python3 {{ playbook_dir }}/../workflows/minio/scripts/generate_warp_report.py {{ playbook_dir }}/../workflows/minio/results/" delegate_to: localhost run_once: true become: false @@ -221,7 +221,7 @@ ignore_errors: true - name: Save benchmark output as fallback - copy: + ansible.builtin.copy: content: | MinIO Warp Benchmark Results ============================ @@ -241,7 +241,7 @@ when: warp_debug is defined - name: Copy fallback results - fetch: + ansible.builtin.fetch: src: "/tmp/warp-results/warp_fallback_{{ ansible_hostname }}_{{ warp_timestamp | default(ansible_date_time.epoch) }}.txt" dest: "{{ playbook_dir }}/../workflows/minio/results/" flat: true -- 2.50.1