[PATCH 1/8] nixos: remove duplicate nixos_channel extra-var from Makefile
Daniel Gomez <[email protected]> Thu, 23 Apr 2026 00:16:42 +0200
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
From: Daniel Gomez <[email protected]> scripts/nixos.Makefile injected nixos_channel=\$(CONFIG_NIXOS_CHANNEL) into ANSIBLE_EXTRA_ARGS, but Kconfig.nixos already declares config NIXOS_CHANNEL with "output yaml", which writes the same key and value into .extra_vars_auto.yaml on every defconfig regeneration. The Ansible extra_vars therefore contained the mapping twice, which ansible-core rightly warns about: [WARNING]: Found duplicate mapping key 'nixos_channel'. Origin: extra_vars.yaml:90:1 Drop the redundant Make assignment. The Kconfig-exported value is authoritative and already drives every consumer. Fixes: 3089c3fec57 ("nixos: add NixOS support as third bringup option with libvirt integration") Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]> --- scripts/nixos.Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/nixos.Makefile b/scripts/nixos.Makefile index 1d8c4e47..d0ad0bf5 100644 --- a/scripts/nixos.Makefile +++ b/scripts/nixos.Makefile @@ -9,7 +9,6 @@ export KDEVOPS_PROVISIONED_SSH := $(KDEVOPS_PROVISIONED_SSH_DEFAULT_GUARD) NIXOS_ARGS += nixos_path='$(TOPDIR_PATH)/nixos' NIXOS_ARGS += data_home_dir=/home/kdevops -NIXOS_ARGS += nixos_channel=$(CONFIG_NIXOS_CHANNEL) NIXOS_ARGS += libvirt_provider=True -- 2.53.0