[PATCH 2/8] nixos: do not emit comment-only recipe lines under $(Q)
Daniel Gomez <[email protected]> Thu, 23 Apr 2026 00:16:43 +0200
| Newsgroups | dev.linux.lists.kdevops |
|---|---|
| Message-ID | <[email protected]> |
From: Daniel Gomez <[email protected]> Under CONFIG_KDEVOPS_MAKE_VERBOSE=y (or V=1) $(Q) expands to a prefix that ends in "&& set -x &&", so a recipe line of the form "$(Q)# comment" becomes "... && set -x && # comment"; the shell treats "#" as a comment, the trailing "&&" loses its right-hand operand, and the recipe aborts with a syntax error. Move prose to Make-level comments above the target so every recipe line is a real command that $(Q) can wrap safely in either verbosity mode. Fixes: 3089c3fec57 ("nixos: add NixOS support as third bringup option with libvirt integration") Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]> --- scripts/nixos.Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/nixos.Makefile b/scripts/nixos.Makefile index d0ad0bf5..7ed49b05 100644 --- a/scripts/nixos.Makefile +++ b/scripts/nixos.Makefile @@ -44,9 +44,10 @@ libvirt_pcie_passthrough_permissions: $(Q)ansible-playbook \ playbooks/libvirt_pcie_passthrough.yml +# SSH connectivity is verified during NixOS VM provisioning: VMs get +# DHCP IPs and SSH is tested directly in the playbook. The marker +# below just records that the provisioning reached that point. $(KDEVOPS_PROVISIONED_SSH): $(KDEVOPS_HOSTS_PREFIX) - $(Q)# The SSH connectivity is verified during NixOS VM provisioning - $(Q)# VMs get DHCP IPs and SSH is tested directly in the playbook $(Q)touch $(KDEVOPS_PROVISIONED_SSH) install_nixos_deps: -- 2.53.0