Re: How to fix problems with the sashiko review model

James Bottomley <[email protected]> Wed, 22 Jul 2026 11:10:45 -0400
Newsgroups dev.linux.lists.ksummit,dev.linux.lists.sashiko-reviews,org.kernel.vger.linux-scsi
Message-ID <8cb7a4a8a13bb003daa1d1413517e104955772d3.camel@HansenPartnership.com>
On Wed, 2026-07-22 at 06:43 -0700, Guenter Roeck wrote:
[...]
> For Sashiko, fork and clone
> https://github.com/sashiko-dev/sashiko.git,
> submit your changes into the clone, and send a pull request. Or at
> least that is how I do it.
>=20
> In the Sashiko source, per-subsystem prompts are located in directory
> third_party/prompts/kernel/subsystem.

OK, now I'm confused.  I thought

https://github.com/masoncl/review-prompts

was the source of truth for this, but that project seems to have been
copied into sashiko rather than pulled in as a module.  If you want to
improve the review prompts do you now have to submit to both (which is
getting to be a bit wasteful)?

Regards,

James